Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(cdk/overlay): Overlay not updating position on scroll #24992

Closed
1 task
jaroslawfrydrych opened this issue May 30, 2022 · 2 comments · Fixed by #25152
Closed
1 task

bug(cdk/overlay): Overlay not updating position on scroll #24992

jaroslawfrydrych opened this issue May 30, 2022 · 2 comments · Fixed by #25152
Assignees
@crisbeto
Labels
area: material.angular.io P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent regression This issue is related to a regression

Comments

@jaroslawfrydrych
Copy link

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

12.2.13

Description

When using a overlay with scroll strategy set RepositionScrollStrategy, position of a overlay is not updaring while scrolling.

Reproduction

Steps to reproduce:

  1. This bug is present in official documentation, as example https://material.angular.io/cdk/overlay/examples

Expected Behavior

In previous version of documentation overlay is working as it should https://v12.material.angular.io/cdk/overlay/examples

Actual Behavior

https://material.angular.io/cdk/overlay/examples

Environment

  • Angular: 13.3.5
  • CDK/Material: 13.3.5
  • Browser(s): Chrome
  • Operating System (e.g. Windows, macOS, Ubuntu): Windows
@jaroslawfrydrych jaroslawfrydrych added the needs triage This issue needs to be triaged by the team label May 30, 2022
@wagnermaciel wagnermaciel added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent regression This issue is related to a regression area: cdk/overlay and removed needs triage This issue needs to be triaged by the team labels Jun 10, 2022
@crisbeto
Copy link
Member

This is an issue with the docs, not the overlay. The scrollable container isn't registered as being a cdkScrollable so the overlay doesn't know that it's supposed to update.

@crisbeto crisbeto mentioned this issue Jun 23, 2022
Closed
1 task
@crisbeto crisbeto self-assigned this Jun 23, 2022
crisbeto added a commit to crisbeto/material2 that referenced this issue Jun 23, 2022
@crisbeto
build: dependencies duplicated when deploying snapshots
1258bd5 
We were adding a `resolutions` field to the package.json of the docs site when deploying it from the main repo to try and control the version that is installed. This appears to be causing an issue where Yarn duplicates the dependencies which in turn causes Webpack to bundle them once for the main site and another for the lazy-loaded chunks with the examples. These changes resolve the issue by not adding the `resolutions` field.

For reference, currently the docs package depends on `@angular/cdk@14.1.0-next.1+sha-7d87068-with-local-changes` whereas the docs site depends on `@angular/cdk@file://path/to/repo/dist/releases/cdk`.

Fixes angular#24992.
@crisbeto crisbeto mentioned this issue Jun 24, 2022
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Jun 24, 2022
@crisbeto
build: dependencies duplicated when deploying snapshots
73e986f 
We were adding a `resolutions` field to the package.json of the docs site when deploying it from the main repo to try and control the version that is installed. This appears to be causing an issue where Yarn duplicates the dependencies which in turn causes Webpack to bundle them once for the main site and another for the lazy-loaded chunks with the examples. These changes resolve the issue by not adding the `resolutions` field.

For reference, currently the docs package depends on `@angular/cdk@14.1.0-next.1+sha-7d87068-with-local-changes` whereas the docs site depends on `@angular/cdk@file://path/to/repo/dist/releases/cdk`.

Fixes angular#24992.
crisbeto added a commit that referenced this issue Jun 24, 2022
@crisbeto
build: dependencies duplicated when deploying snapshots (#25152)
8bca5e1 
We were adding a `resolutions` field to the package.json of the docs site when deploying it from the main repo to try and control the version that is installed. This appears to be causing an issue where Yarn duplicates the dependencies which in turn causes Webpack to bundle them once for the main site and another for the lazy-loaded chunks with the examples. These changes resolve the issue by not adding the `resolutions` field.

For reference, currently the docs package depends on `@angular/cdk@14.1.0-next.1+sha-7d87068-with-local-changes` whereas the docs site depends on `@angular/cdk@file://path/to/repo/dist/releases/cdk`.

Fixes #24992.

(cherry picked from commit 4cedd6b)
crisbeto added a commit that referenced this issue Jun 24, 2022
@crisbeto
build: dependencies duplicated when deploying snapshots (#25152)
4cedd6b 
We were adding a `resolutions` field to the package.json of the docs site when deploying it from the main repo to try and control the version that is installed. This appears to be causing an issue where Yarn duplicates the dependencies which in turn causes Webpack to bundle them once for the main site and another for the lazy-loaded chunks with the examples. These changes resolve the issue by not adding the `resolutions` field.

For reference, currently the docs package depends on `@angular/cdk@14.1.0-next.1+sha-7d87068-with-local-changes` whereas the docs site depends on `@angular/cdk@file://path/to/repo/dist/releases/cdk`.

Fixes #24992.
crisbeto added a commit that referenced this issue Jun 24, 2022
@crisbeto
build: dependencies duplicated when deploying snapshots (#25152)
5568f90 
We were adding a `resolutions` field to the package.json of the docs site when deploying it from the main repo to try and control the version that is installed. This appears to be causing an issue where Yarn duplicates the dependencies which in turn causes Webpack to bundle them once for the main site and another for the lazy-loaded chunks with the examples. These changes resolve the issue by not adding the `resolutions` field.

For reference, currently the docs package depends on `@angular/cdk@14.1.0-next.1+sha-7d87068-with-local-changes` whereas the docs site depends on `@angular/cdk@file://path/to/repo/dist/releases/cdk`.

Fixes #24992.

(cherry picked from commit 4cedd6b)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
area: material.angular.io P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent regression This issue is related to a regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: dependencies duplicated when deploying snapshots crisbeto/material2
3 participants
@crisbeto @jaroslawfrydrych @wagnermaciel