build: do not load tslib and moment twice in tests #14715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* SystemJS is responsible for loading `tslib` and `moment` as registered AMD modules. This means that we don't need to include them in Karma as well. Currently the browsers fetches Moment and tslib twice and also runs it without having any necessary effect.
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
* SystemJS is responsible for loading `tslib` and `moment` as registered AMD modules. This means that we don't need to include them in Karma as well. Currently the browsers fetches Moment and tslib twice and also runs it without having any necessary effect.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SystemJS is responsible for loading
tslibandmomentas registered AMD modules. This means that we don't need to include them in Karma as well.Currently the browsers fetches Moment and tslib twice and also runs it without having any necessary effect.