Skip to content

Conversation

@mmalerba
Copy link
Contributor

Reverts #16231

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 10, 2019
@mmalerba mmalerba merged commit 7f74211 into master Jun 10, 2019
@devversion
Copy link
Member

To provide more context about this: It had to be reverted because there is a transform when the code gets synced into Google3. e.g. new code is inserted that depends on the Version symbol to be imported.

This is actually causing exceptions as #16231 removed the imported Version symbol. We need a general discussion on how we want to manage versions.. This is not a high priority for now.

RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
@josephperrott josephperrott deleted the revert-16231-refactor/core-remove-version-placeholder-workaround branch June 29, 2022 18:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants