Skip to content

refactor(cdk/table): remove deprecated APIs for version 10 #19310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2020
Merged

refactor(cdk/table): remove deprecated APIs for version 10 #19310

merged 1 commit into from
May 13, 2020

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented May 10, 2020

Removes the APIs that have been deprecated for v10.

BREAKING CHANGES:

  • CdkTable.setHeaderRowDef has been removed. Use CdkTable.addHeaderRowDef and CdkTable.removeHeaderRowDef instead.
  • CdkTable.setFooterRowDef has been removed. Use CdkTable.addFooterRowDef and CdkTable.removeFooterRowDef instead.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels May 10, 2020
@crisbeto crisbeto added this to the 10.0.0 milestone May 10, 2020
@crisbeto crisbeto requested a review from andrewseguin as a code owner May 10, 2020 13:59
@crisbeto crisbeto requested a review from a team May 10, 2020 13:59
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 10, 2020
@crisbeto
refactor(cdk/table): remove deprecated APIs for version 10
84e2610 
Removes the APIs that have been deprecated for v10.

BREAKING CHANGES:
* `CdkTable.setHeaderRowDef` has been removed. Use `CdkTable.addHeaderRowDef` and `CdkTable.removeHeaderRowDef` instead.
* `CdkTable.setFooterRowDef` has been removed. Use `CdkTable.addFooterRowDef` and `CdkTable.removeFooterRowDef` instead.
@crisbeto crisbeto force-pushed the table-v10-deprecated-methods branch from 833f467 to 84e2610 Compare May 10, 2020 14:01
jelbourn
jelbourn approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels May 11, 2020
@mmalerba mmalerba merged commit 06921ff into angular:master May 13, 2020
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jun 13, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

@andrewseguin andrewseguin

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@crisbeto @jelbourn @devversion @googlebot @mmalerba @andrewseguin