Skip to content

refactor(autocomplete): change deprecated APIs for version 10 #19325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jelbourn merged 1 commit into from
May 26, 2020
Merged

refactor(autocomplete): change deprecated APIs for version 10 #19325

jelbourn merged 1 commit into from
May 26, 2020

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented May 11, 2020

Changes the APIs that were marked as deprecated for v10.

BREAKING CHANGES:

  • The _viewportRuler parameter in the MatAutocompleteTrigger constructor is now required.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels May 11, 2020
@crisbeto crisbeto added this to the 10.0.0 milestone May 11, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 11, 2020
jelbourn
jelbourn approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels May 12, 2020
@crisbeto crisbeto force-pushed the autocomplete-breaking-changes-v10 branch from 519263a to 4b5162d Compare May 15, 2020 17:23
@jelbourn
Copy link
Member

jelbourn commented May 21, 2020

@crisbeto passes presubmit, just needs rebase

@crisbeto crisbeto force-pushed the autocomplete-breaking-changes-v10 branch from 4b5162d to 20524c7 Compare May 23, 2020 10:06
@crisbeto
refactor(autocomplete): change deprecated APIs for version 10
9de0ca7 
Changes the APIs that were marked as deprecated for v10.

BREAKING CHANGES:
* The `_viewportRuler` parameter in the `MatAutocompleteTrigger` constructor is now required.
@crisbeto crisbeto force-pushed the autocomplete-breaking-changes-v10 branch from 20524c7 to 9de0ca7 Compare May 26, 2020 17:24
@jelbourn jelbourn merged commit 25d2e05 into angular:master May 26, 2020
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jun 26, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto @jelbourn @googlebot