Skip to content

refactor(youtube-player): change deprecated APIs for version 10 #19348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2020
Merged

refactor(youtube-player): change deprecated APIs for version 10 #19348

merged 1 commit into from
May 15, 2020

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented May 13, 2020

Changes the APIs that were marked as deprecated in the youtube-player module.

BREAKING CHANGES:

  • The platformId parameter of the YouTubePlayer constructor is now required.

@crisbeto crisbeto requested a review from jelbourn as a code owner May 13, 2020 19:49
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 13, 2020
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels May 13, 2020
@crisbeto crisbeto added this to the 10.0.0 milestone May 13, 2020
@crisbeto
refactor(youtube-player): change deprecated APIs for version 10
9f8ff53 
Changes the APIs that were marked as deprecated in the `youtube-player` module.

BREAKING CHANGES:
* The `platformId` parameter of the `YouTubePlayer` constructor is now required.
@crisbeto crisbeto force-pushed the youtube-player-v10-breaking-changes branch from 8d48e7c to 9f8ff53 Compare May 13, 2020 20:00
jelbourn
jelbourn approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels May 13, 2020
@mmalerba mmalerba merged commit eaff142 into angular:master May 15, 2020
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jun 15, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto @jelbourn @googlebot @mmalerba