Skip to content

refactor(sort): change deprecated APIs for version 10 #19372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2020
Merged

refactor(sort): change deprecated APIs for version 10 #19372

merged 1 commit into from
May 26, 2020

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented May 15, 2020

Cleans up the APIs that were marked as deprecated for v10.

BREAKING CHANGES:

  • The _focusMonitor and _elementRef parameters in the MatSortHeader constructor are now required.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels May 15, 2020
@crisbeto crisbeto added this to the 10.0.0 milestone May 15, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 15, 2020
jelbourn
jelbourn approved these changes May 15, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels May 15, 2020
@jelbourn
Copy link
Member

jelbourn commented May 21, 2020

@crisbeto passes presubmit, just needs rebase

@crisbeto
refactor(sort): change deprecated APIs for version 10
693503e 
Cleans up the APIs that were marked as deprecated for v10.

BREAKING CHANGES:
* The `_focusMonitor` and `_elementRef` parameters in the `MatSortHeader` constructor are now required.
@crisbeto crisbeto force-pushed the sort-v10-breaking-changes branch from 1a942f0 to 693503e Compare May 21, 2020 07:00
@crisbeto
Copy link
Member Author

crisbeto commented May 21, 2020

Rebased.

@jelbourn jelbourn merged commit 1f2ff16 into angular:master May 26, 2020
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jun 26, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

@andrewseguin andrewseguin

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@crisbeto @jelbourn @devversion @googlebot @andrewseguin