Skip to content

refactor(material/schematics): support extra variables in themingApi … #22741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2021
Merged

refactor(material/schematics): support extra variables in themingApi … #22741

merged 1 commit into from
May 20, 2021

Conversation

@jelbourn
Copy link
Member

@jelbourn jelbourn commented May 20, 2021

…migration

Adding support for extra variables to handle some Google-internal variables that need to be migrated as well.

@jelbourn
refactor(material/schematics): support extra variables in themingApi …
23ad037 
…migration

Adding support for extra variables to handle some Google-internal variables that need to be migrated as well.
@jelbourn jelbourn added P2 The issue is important to a large percentage of users, with a workaround merge safe area: ng-update Issues related to `ng-update` integration labels May 20, 2021
@jelbourn jelbourn requested a review from crisbeto May 20, 2021 14:47
@jelbourn jelbourn requested a review from devversion as a code owner May 20, 2021 14:47
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 20, 2021
wagnermaciel
wagnermaciel approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wagnermaciel wagnermaciel added the action: merge The PR is ready for merge by the caretaker label May 20, 2021
@jelbourn jelbourn added the target: patch This PR is targeted for the next patch release label May 20, 2021
@wagnermaciel wagnermaciel added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels May 20, 2021
@wagnermaciel wagnermaciel merged commit 284bdaa into angular:master May 20, 2021
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jun 20, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto

@devversion devversion Awaiting requested review from devversion

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: ng-update Issues related to `ng-update` integration cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jelbourn @wagnermaciel