Skip to content

fix(menu): close menu panel on escape #4666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2017
Merged

fix(menu): close menu panel on escape #4666

merged 1 commit into from
May 22, 2017

Conversation

@jelbourn
Copy link
Member

Fixes to #3601

@jelbourn jelbourn requested a review from crisbeto May 19, 2017 01:22
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 19, 2017
@jelbourn jelbourn added Accessibility This issue is related to accessibility (a11y) and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels May 19, 2017
crisbeto
crisbeto approved these changes May 19, 2017
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 19, 2017
@tinayuangao tinayuangao merged commit 210e57c into angular:master May 22, 2017
@willshowell willshowell mentioned this pull request May 30, 2017
Closed
@jelbourn jelbourn deleted the menu-escape branch September 13, 2017 04:38
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees

No one assigned

Labels

Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jelbourn @crisbeto @googlebot @tinayuangao