From 33049cff96cd643e76159fc2d72cbd9fb911245c Mon Sep 17 00:00:00 2001 From: Julian Wielga Date: Tue, 17 Mar 2015 16:40:55 +0100 Subject: [PATCH] fix(gridlist): update calcs for safari StyleString was too big for safari to parse when appending with innerHTML Fixed typo in Grid list in safari Closes #2066. --- src/components/gridList/gridList.js | 2 +- src/core/services/theming/theming.js | 38 ++++++++++++++++------------ 2 files changed, 23 insertions(+), 17 deletions(-) diff --git a/src/components/gridList/gridList.js b/src/components/gridList/gridList.js index 2f27aeedeae..9617bc0e6c3 100644 --- a/src/components/gridList/gridList.js +++ b/src/components/gridList/gridList.js @@ -204,7 +204,7 @@ function GridListDirective($interpolate, $mdConstant, $mdGridLayout, $mdMedia) { // The horizontal or vertical position of a tile, e.g., the 'top' or 'left' property value. // The position comes the size of a 1x1 tile plus gutter for each previous tile in the // row/column (offset). - var POSITION = $interpolate('calc( ( ({{unit}}) + {{gutter}} ) * {{offset}} '); + var POSITION = $interpolate('calc( ( {{unit}} + {{gutter}} ) * {{offset}} )'); // The actual size of a tile, e.g., width or height, taking rowSpan or colSpan into account. // This is computed by multiplying the base unit by the rowSpan/colSpan, and then adding back diff --git a/src/core/services/theming/theming.js b/src/core/services/theming/theming.js index e9869c2bbe7..305717295a0 100644 --- a/src/core/services/theming/theming.js +++ b/src/core/services/theming/theming.js @@ -360,7 +360,7 @@ function ThemableDirective($mdTheming) { return $mdTheming; } -function parseRules(theme, colorType, rules) { +function _parseRules(theme, colorType, rules) { checkValidPalette(theme, colorType); rules = rules.replace(/THEME_NAME/g, theme.name); @@ -402,7 +402,11 @@ function parseRules(theme, colorType, rules) { generatedRules.push(newRule); }); - return generatedRules.join(''); + return generatedRules; +} + +function parseRules(theme, colorType, rules) { + return _parseRules(theme, colorType, rules).join(''); } // Generate our themes at run time given the state of THEMES and PALETTES @@ -448,29 +452,31 @@ function generateThemes($injector) { return rulesByType[DEFAULT_COLOR_TYPE] += rule; }); - var styleString = ''; - // For each theme, use the color palettes specified for `primary`, `warn` and `accent` // to generate CSS rules. angular.forEach(THEMES, function(theme) { - THEME_COLOR_TYPES.forEach(function(colorType) { - styleString += parseRules(theme, colorType, rulesByType[colorType] + ''); - }); + // Insert our newly minted styles into the DOM + if (!generationIsDone) { + var head = document.getElementsByTagName('head')[0]; + var headFirstElementChild = head.firstElementChild; + THEME_COLOR_TYPES.forEach(function(colorType) { + var styleStrings = _parseRules(theme, colorType, rulesByType[colorType]); + while(styleStrings.length) { + var style = document.createElement('style'); + style.setAttribute('type', 'text/css'); + style.appendChild(document.createTextNode(styleStrings.shift())); + head.insertBefore(style, headFirstElementChild); + } + }); + generationIsDone = true; + } + if (theme.colors.primary.name == theme.colors.accent.name) { console.warn("$mdThemingProvider: Using the same palette for primary and" + " accent. This violates the material design spec."); } }); - // Insert our newly minted styles into the DOM - if (!generationIsDone) { - var style = document.createElement('style'); - style.innerHTML = styleString; - var head = document.getElementsByTagName('head')[0]; - head.insertBefore(style, head.firstElementChild); - generationIsDone = true; - } - // The user specifies a 'default' contrast color as either light or dark, // then explicitly lists which hues are the opposite contrast (eg. A100 has dark, A200 has light) function sanitizePalette(palette) {