Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Commit

Permalink
fix(local): Ensure webdriver.gecko.driver path is passed to Selenium (#…
Browse files Browse the repository at this point in the history
…4502)

Always pass webdriver.gecko.driver property to Selenium if set in local
mode. fixes #4501
  • Loading branch information
bdellegrazie authored and qiyigg committed Jun 4, 2018
1 parent 1c6a1a8 commit 3702a70
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions lib/driverProviders/local.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ import {Logger} from '../logger';
import {DriverProvider} from './driverProvider';

const SeleniumConfig = require('webdriver-manager/built/lib/config').Config;
const SeleniumChrome = require('webdriver-manager/built/lib/binaries/chrome_driver').ChromeDriver;
const SeleniumStandAlone = require('webdriver-manager/built/lib/binaries/standalone').StandAlone;
const remote = require('selenium-webdriver/remote');

let logger = new Logger('local');
Expand Down Expand Up @@ -151,6 +149,9 @@ export class Local extends DriverProvider {
if (this.config_.chromeDriver) {
serverConf.jvmArgs.push('-Dwebdriver.chrome.driver=' + this.config_.chromeDriver);
}
if (this.config_.geckoDriver) {
serverConf.jvmArgs.push('-Dwebdriver.gecko.driver=' + this.config_.geckoDriver);
}

this.server_ = new remote.SeleniumServer(this.config_.seleniumServerJar, serverConf);

Expand Down

0 comments on commit 3702a70

Please sign in to comment.