fix(local): Ensure webdriver.gecko.driver path is passed to Selenium

Always pass webdriver.gecko.driver property to Selenium if set in local mode fixes #4501
angular · Sep 22, 2017 · 7f67175 · 7f67175
1 parent 15776b8
commit 7f67175
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/lib/driverProviders/local.ts b/lib/driverProviders/local.ts
@@ -17,8 +17,6 @@ import {Logger} from '../logger';
 import {DriverProvider} from './driverProvider';
 
 const SeleniumConfig = require('webdriver-manager/built/lib/config').Config;
-const SeleniumChrome = require('webdriver-manager/built/lib/binaries/chrome_driver').ChromeDriver;
-const SeleniumStandAlone = require('webdriver-manager/built/lib/binaries/standalone').StandAlone;
 const remote = require('selenium-webdriver/remote');
 
 let logger = new Logger('local');
@@ -151,6 +149,9 @@ export class Local extends DriverProvider {
  if (this.config_.chromeDriver) {
  serverConf.jvmArgs.push('-Dwebdriver.chrome.driver=' + this.config_.chromeDriver);
  }
+ if (this.config_.geckoDriver) {
+ serverConf.jvmArgs.push('-Dwebdriver.gecko.driver=' + this.config_.geckoDriver);
+ }
 
  this.server_ = new remote.SeleniumServer(this.config_.seleniumServerJar, serverConf);