Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

CLI: error when specifying single value config arrays from command line #4050

Closed
zuzusik opened this issue Feb 1, 2017 · 0 comments
Closed

CLI: error when specifying single value config arrays from command line #4050

zuzusik opened this issue Feb 1, 2017 · 0 comments
Labels
status: fixed for next release

Comments

@zuzusik
Copy link

zuzusik commented Feb 1, 2017 •
edited
Loading

Protractor version: 5.0.0
Browser: Chrome 56.0.2924.76
Chromedriver: 2.26.436421
directConnect: true

Currently to specify capabilities.chromeOptions.args from command line I am forced to add fake argument so that it is parsed as array in config:

--capabilities.chromeOptions.args=--no-sandbox --capabilities.chromeOptions.args=--fake-arg

If specifying just --capabilities.chromeOptions.args=--no-sandbox then it is parsed not as array with single string, but as single string and I get the following error:

[19:31:30] E/launcher - WebDriverError: unknown error: cannot parse capability: chromeOptions
from unknown error: cannot parse args
from unknown error: each argument must be a string
@zuzusik zuzusik changed the title CLI: specifying single value config arrays from command line CLI: error when specifying single value config arrays from command line Feb 2, 2017
NickTomlin added a commit to NickTomlin/protractor that referenced this issue Feb 26, 2017
@NickTomlin
fix(cli): Correctly parse list chromeOptions
903c301 
Chromedriver requires that certain options always be passed as an array.
Optimist passes --single-option as a string instead of an array which is
invalid. This ensures that we always pass an array, even if a single
option is passed via the cli.

Fixes angular#4050
@NickTomlin NickTomlin mentioned this issue Feb 26, 2017
Merged
NickTomlin added a commit to NickTomlin/protractor that referenced this issue Feb 26, 2017
@NickTomlin
fix(cli): Correctly parse list chromeOptions
e0ab9bd 
Chromedriver requires that certain options always be passed as an array.
Optimist passes --single-option as a string instead of an array which is
invalid. This ensures that we always pass an array, even if a single
option is passed via the cli.

Fixes angular#4050
NickTomlin added a commit to NickTomlin/protractor that referenced this issue Mar 3, 2017
@NickTomlin
fix(cli): Correctly parse list chromeOptions
c6ec095 
Chromedriver requires that certain options always be passed as an array.
Optimist passes --single-option as a string instead of an array which is
invalid. This ensures that we always pass an array, even if a single
option is passed via the cli.

Fixes angular#4050
NickTomlin added a commit to NickTomlin/protractor that referenced this issue Mar 3, 2017
@NickTomlin
fix(cli): Correctly parse list chromeOptions
2931f4a 
Chromedriver requires that certain options always be passed as an array.
Optimist passes --single-option as a string instead of an array which is
invalid. This ensures that we always pass an array, even if a single
option is passed via the cli.

Fixes angular#4050
heathkit pushed a commit that referenced this issue May 3, 2017
@NickTomlin @heathkit
fix(cli): Correctly parse list chromeOptions
1250278 
Chromedriver requires that certain options always be passed as an array.
Optimist passes --single-option as a string instead of an array which is
invalid. This ensures that we always pass an array, even if a single
option is passed via the cli.

Fixes #4050
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: fixed for next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@heathkit @zuzusik