Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Update Page Objects doc for testing with node 8 async/await #4637

Closed
vsravuri opened this issue Dec 21, 2017 · 1 comment
Closed

Update Page Objects doc for testing with node 8 async/await #4637

vsravuri opened this issue Dec 21, 2017 · 1 comment
Labels

Comments

@vsravuri
Copy link

Bug report

  • Node Version: v8.9.3
  • Protractor Version: 5.2.2

The latest Node.js provides native async/await. Control flow will be completely removed in future version of Selenium [Selenium 4.0]. The Page Object example provided in the http://www.protractortest.org/#/page-objects document is written using Control Flow.

I've referred to the http://www.protractortest.org/#/async-await document to understand how to convert a spec file written in Control Flow to async/await but struggling to find an example to convert the Page Objects written in Control flow to async/await.

Requirement:
Update the existing Page Object document to include an example to write Page Object using Node async/await. The examples in existing Page Object document will be obsolete after Control Flow is removed from Selenium.

@qiyigg
Copy link
Contributor

qiyigg commented Jan 25, 2018

This was done by #4675.
Close the issue

@qiyigg qiyigg closed this as completed Jan 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants