Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Breaking Change in 5.1.1 to change default selenium relay protocol to 'https' #4770

Closed
martin770 opened this issue Apr 9, 2018 · 2 comments

Comments

@martin770
Copy link
Contributor

A feature was added in protractor 5.1.1 that broke my ability to run tests on sauce labs.

feat(saucelabs): Add Sauce Labs HTTPS Support (#4071) -- commit

Version 5.1.1 added this commit to change the default protocol for the sauce labs selenium relay to 'https' instead of the previous 'http'. This should be pointed out as a breaking change in the changelog.md file.

Version 5.1.2 added the ability to change the protocol via a new configuration option (protractor.conf.js sauceSeleniumUseHttp). This new configuration option should be mentioned in the changelog.

It took me a bit of time to track down the problem as I was upgrading from 4.0.14 to 5.2.0. And in this case, 5.1.1 is completely unusable on sauce labs.

Bug report

  • Node Version: 6.9.1
  • Protractor Version: 5.1.2
  • Angular Version: n/a
  • Browser(s): any (sauce labs via sauce-connect-launcher)
  • Operating System and Version linux
  • Your protractor configuration file
    (sauceSeleniumAddress points to selenium relay started via the sauce-connect-launcher npm module)
    sauceSeleniumAddress: localhost:47521/wd/hub
    sauceSeleniumUseHttp: null
  • A relevant example test any
  • Output from running the test
    [12:55:21] E/launcher - EPROTO write EPROTO 139622020233088:error:140770FC:SSL routines:SSL23_GET_SERVER_HELLO:unknown protocol:../deps/openssl/openssl/ssl/s23_clnt.c:794:
@qiyigg
Copy link
Contributor

qiyigg commented May 1, 2018

Would you mind sending a PR for this? Since you have a clear understanding of this problem

@martin770
Copy link
Contributor Author

Pull Request #4793

#4793

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants