This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
chore(examples): update async/await example with better info #3693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnishina
approved these changes
Nov 7, 2016
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Jul 31, 2017
- Add gecko driver as configuration option to be used in the local
driver provider.
- Nit fixes to use string[] over Array<string> in the configParser.ts.
- Add functionality to addDefaultBinaryLocs_ to use the geckoDriver
value set in the config or to check locally in the
webdriver-manager/selenium folder.
- Fix transpile errors in locator. Missing toString in ProtractorLocator
interface.
- Fix transpile errors in element. Cast wdpromise.Promise<{}> to
wdpromise.Promise<T>.
- xit spec/basic/action_spec.js based on
[selenium-webdriver issue angular#3693](SeleniumHQ/selenium#3693).
Added a // TODO comment to remove xit when selenium-webdriver resolves issue.
closes angular#4408 and closes angular#4411.
cnishina
added a commit
that referenced
this pull request
Jul 31, 2017
…ig (#4412) - Add gecko driver as configuration option to be used in the local driver provider. - Nit fixes to use `string[]` over `Array<string>` in the configParser.ts. - Add functionality to `addDefaultBinaryLocs_` to use the `geckoDriver` value set in the config or to check locally in the `webdriver-manager/selenium` folder. - Fix transpile errors in locator. Missing toString in ProtractorLocator interface. - Fix transpile errors in element. Cast wdpromise.Promise<{}> to wdpromise.Promise<T>. - xit spec/basic/action_spec.js based on [selenium-webdriver issue #3693](SeleniumHQ/selenium#3693). Added a // TODO comment to remove xit when selenium-webdriver resolves issue. closes #4408 and closes #4411.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.