This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
fix(firefox): Fix directConnect for Firefox 51+ #3953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heathkit
force-pushed
the
firefox-51-direct
branch
2 times, most recently
from
25c3580
to
33e573c
Compare
|
Putting this on hold for now. We can manually install the beta on circle and test with direct connect, but the other tests against Firefox need selenium server. It's too much work to have some tests in Circle on Firefox 51 and some on Firefox 47, so I'm going to wait a bit for Firefox 51 to be released and hopefully a new selenium server release. |
|
So this works now. Users that want to use Firefox 51+ will need to use selenium server 3.0.0-beta4, using the same method that the circle.yml does. |
juliemr
approved these changes
Jan 18, 2017
| @@ -14,11 +14,17 @@ dependencies: | |||
| post: | |||
| - ./node_modules/.bin/gulp lint | |||
| - ./node_modules/.bin/webdriver-manager update | |||
| - ./node_modules/.bin/webdriver-manager start: | |||
| background: true | |||
| - wget http://selenium-release.storage.googleapis.com/3.0-beta4/selenium-server-standalone-3.0.0-beta4.jar -P ./node_modules/webdriver-manager/selenium | |||
There was a problem hiding this comment.
Note to self: Can't use 3.0.0 or 3.0.1, as these both have a bug that breaks firefox.
heathkit
force-pushed
the
firefox-51-direct
branch
from
d06034c
to
eff8a60
Compare
igniteram
pushed a commit
to igniteram/protractor
that referenced
this pull request
Feb 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3823.