This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
chore(quitDriver): have quitDriver return a webdriver promise directly #3992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapping it in a `q` promise is blocking angular#3899 Closes angular#3902 Custom frameworks might not make this change but it'll be fine. It'll only be a problem in edge cases and they probably weren't returning the right promise before anyway.
juliemr
approved these changes
Jan 20, 2017
|
LGTM once Travis is happy. |
sjelin
added a commit
to sjelin/protractor
that referenced
this pull request
Jan 27, 2017
angular#3992) Wrapping it in a `q` promise is blocking angular#3899 Closes angular#3902 Custom frameworks might not make this change but it'll be fine. It'll only be a problem in edge cases and they probably weren't returning the right promise before anyway.
igniteram
pushed a commit
to igniteram/protractor
that referenced
this pull request
Feb 21, 2017
angular#3992) Wrapping it in a `q` promise is blocking angular#3899 Closes angular#3902 Custom frameworks might not make this change but it'll be fine. It'll only be a problem in edge cases and they probably weren't returning the right promise before anyway.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapping it in a
qpromise is blocking #3899Closes #3902
Custom frameworks might not make this change but it'll be fine. It'll only be a
problem in edge cases and they probably weren't returning the right promise
before anyway.