chore(release): version bump and update changelog for 5.1 #4046
Conversation
|
Please change the commit title to include "for 5.1" for ease of future searches |
cnishina
changed the title
CHANGELOG.md
Outdated
|
|
||
| #### Breaking changes summary: | ||
|
|
||
| - `browser.getLocationAbsUrl` deprecated |
There was a problem hiding this comment.
Clarify that this was deprecated, and has now been removed.
There was a problem hiding this comment.
Sorry, my bad, it has NOT been removed just deprecated.
There was a problem hiding this comment.
Removed "breaking change" since it is more of a "fix"
CHANGELOG.md
Outdated
| #### Breaking changes summary: | ||
|
|
||
| - `browser.getLocationAbsUrl` deprecated | ||
| - Replaced `browser.rootEl` with `browser.angularAppRoot()` |
There was a problem hiding this comment.
Note that browser.rootEl will still work - so I'd prefer to not list this here.
There was a problem hiding this comment.
Removed section so ignore this.
CHANGELOG.md
Outdated
| - `browser.getLocationAbsUrl` deprecated | ||
| - Replaced `browser.rootEl` with `browser.angularAppRoot()` | ||
|
|
||
| ## Bug Fixes |
There was a problem hiding this comment.
Please move the feature section up above the bug fixes session.
CHANGELOG.md
Outdated
| While paused, the element that's about to be affected will be | ||
| highlighted. | ||
|
|
||
| - ([8d2fc07](https://github.com/angular/protractor/commit/8d2fc07ed28a1b19c03a9869442f76f2963e40a1)) |
There was a problem hiding this comment.
Just move this whole thing into the breaking changes section and out of here.
There was a problem hiding this comment.
Nevermind, ignore, either keep it here or move to fixes.
There was a problem hiding this comment.
Moving this to the "fix" section
| closes #4033 | ||
|
|
||
| - ([cd084a0](https://github.com/angular/protractor/commit/cd084a0ca29cd73aa3ce1650188adf7ddfdb7962)) | ||
| deps(jasmine): update jasmine to ^2.5.3 (#3960) |
There was a problem hiding this comment.
Is this where we should talk about @types/jasminewd?
There was a problem hiding this comment.
Added a section at the top to highlight this.
|
LGTM |
No description provided.