fix(local): Ensure webdriver.gecko.driver path is passed to Selenium

[bdellegrazie]

Always pass webdriver.gecko.driver property to Selenium if set in local
mode

fixes #4501

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
• In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
• In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

[bdellegrazie]

I signed it!

[googlebot]

CLAs look good, thanks!

[googlebot]

CLAs look good, thanks!

[wswebcreation]

Hi @bdellegrazie

Isn't this also related to this #4412?

@cnishina I've added you as a reviewer because you were also busy with the previous PR

[bdellegrazie]

@wswebcreation: yes it is ... but that PR was merged, adds webdriver.chrome.driver but not webdriver.gecko.driver ... all this does is "finish" it.
If you'd prefer me to add this to that PR, I'm happy to do so.

[wswebcreation]

Tnx for the reply. I can, but may not merge it. I'll let that up to the core team ;-)

[costescuandrei]

So this pull req. is not merged because of the timed out command in tests?

[bdellegrazie]

I've rebased the change in the hope the tests pass this time.

[bdellegrazie]

All tests have passed @wswebcreation @costescuandrei can someone from the core team please merge?

[bdellegrazie]

@cnishina any chance of a review please?

[bdellegrazie]

Can anyone get this trivial change merged?

[costescuandrei]

+1 for merging this in & Thanks @bdellegrazie for updating it.

[qiyigg]

Thanks. Merged.