fix(direct): Use config's geckoDriver when specified

[shaungrady]

This change makes the firefox capability more closely match chrome's. The firefox capability was not looking for config_.geckoDriver like chrome was, making the geckoDriver configuration useless for directConnect and always resulting in an error if the driver wasn't installed in the default location.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
• In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
• In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

[shaungrady]

I signed it!

[googlebot]

CLAs look good, thanks!

[googlebot]

CLAs look good, thanks!

[talolierwork]

Hitting that problem, waiting for that fix...

BTW, we wrote a small script which copies the gecko driver from the protractor node modeules.
We run it in the "pree2e": "./update_webdriver.sh" (in the package.json)
Here is the script:

Download selenium drivers

./node_modules/protractor/node_modules/webdriver-manager/bin/webdriver-manager update --versions.standalone 3.6.0

Copy the Gecko driver

driver_directory=./node_modules/protractor/node_modules/webdriver-manager/selenium
echo Looking for Gecko driver in: $driver_directory
filename=$(ls $driver_directory | grep '.geckodriver.[0-9]$' | sort | tail -1)
echo Lastest gecko driver found: $filename
cp $driver_directory/$filename ./geckodriver
echo Driver copied.

[shaungrady]

Yeah we did the same thing to work around it.

[shaungrady]

@juliemr This is a real simple fix. Can you—or someone else I should ping—take a look at this please?