Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Update config.ts sauceSeleniumAddress comment to reflect 443 default #5041

Merged
merged 1 commit into from
Nov 14, 2018
Merged

Update config.ts sauceSeleniumAddress comment to reflect 443 default #5041

merged 1 commit into from
Nov 14, 2018

Conversation

enriquegh
Copy link
Contributor

Per the default behavior set in:
https://github.com/angular/protractor/blob/master/lib/driverProviders/sauce.ts#L68-L70

the Sauce OnDemand address will default to ondemand.saucelabs.com:443 unless changed.
The config.ts doc says the default is ondemand.saucelabs.com:80.

This PR simply changes the port number on the config.ts comment.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@enriquegh
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@cnishina cnishina merged commit d4fe1ca into angular:master Nov 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants