This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
chore(promises): move element wdpromise to native Promise #5047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Work in progress. I want to pass the full CI (not on my computer) |
cnishina
force-pushed
the
you_made_me_promises_promises
branch
from
9873b32
to
4fcad51
Compare
cnishina
force-pushed
the
you_made_me_promises_promises
branch
from
4fcad51
to
86b4dcd
Compare
cnishina
force-pushed
the
you_made_me_promises_promises
branch
from
1ef106d
to
e276c6a
Compare
CrispusDH
reviewed
Nov 16, 2018
CrispusDH
reviewed
Nov 16, 2018
CrispusDH
reviewed
Nov 16, 2018
| return wdpromise.fullyResolved(mapResult) as wdpromise.Promise<T>; | ||
| }); | ||
| return wdpromise.all(list); | ||
| async map<T>(mapFn: (elementFinder?: ElementFinder, index?: number) => T | any): Promise<T[]> { |
There was a problem hiding this comment.
it would be great if we add tests for map, filter, each, reduce functions with big (ten for example) elements in array. Protractor has a big concurrent issue with it. In my common usage I wrapped Fn function to be sequential instead of concurrent. I don't know, maybe it was resolved in selenium4 but again would be nice to have some tests to cover this case.
There was a problem hiding this comment.
Could you write an issue about this? We will address this later. (Procrastination 😛)
cnishina
force-pushed
the
you_made_me_promises_promises
branch
from
0474681
to
abe590c
Compare
cnishina
force-pushed
the
you_made_me_promises_promises
branch
from
abe590c
to
179622a
Compare
heathkit
approved these changes
Nov 19, 2018
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Dec 19, 2018
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Mar 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.