This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
chore(config): Update docs regarding proxies #5048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change tries to make the different proxies available easier to differentiate. The sauceAgent key's comment said that adding a webDriverProxy would override this and this is not true. sauceAgent is overwritten by sauceProxy since both are passed onto the saucelabs module. See: https://github.com/angular/protractor/blob/master/lib/driverProviders/sauce.ts#L60-L61 webDriverProxy on the other hand is passed onto the WebDriver session. See: https://github.com/angular/protractor/blob/master/lib/driverProviders/driverProvider.ts#L54 This means that if you're under a corporate proxy and need to proxy both Sauce Labs API calls as well as calls to the Selenium endpoint (ondemand.saucelabs.com) both sauceProxy/sauceAgent and webDriverProxy need to be used.
cnishina
approved these changes
Dec 18, 2018
| * This is needed if your computer is behind a corporate proxy. | ||
| * | ||
| * To match sauce agent implementation, use | ||
| * [HttpProxyAgent](https://github.com/TooTallNate/node-http-proxy-agent) | ||
| * to generate the agent or use webDriverProxy as an alternative. If a | ||
| * webDriverProxy is provided, the sauceAgent will be overridden. |
There was a problem hiding this comment.
Sure. I remember trying to set it all to webDriverProxy at one point 3 years ago...
cnishina
pushed a commit
to cnishina/protractor
that referenced
this pull request
Dec 19, 2018
This change updates documentation on the different proxies. The sauceAgent key's comment said that adding a webDriverProxy would override this and this is not true. sauceAgent is overwritten by sauceProxy since both are passed onto the saucelabs module. This means that if you are under a corporate proxy and need to proxy both Sauce Labs API calls as well as calls to the Selenium endpoint (ondemand.saucelabs.com) both sauceProxy/sauceAgent and webDriverProxy need to be used.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change tries to make the different proxies available easier to differentiate.
The sauceAgent key's comment said that adding a webDriverProxy would override this and this is not true.
sauceAgent is overwritten by sauceProxy since both are passed onto the saucelabs module.
See:
https://github.com/angular/protractor/blob/master/lib/driverProviders/sauce.ts#L60-L61
webDriverProxy on the other hand is passed onto the WebDriver session.
See:
https://github.com/angular/protractor/blob/master/lib/driverProviders/driverProvider.ts#L54
This means that if you're under a corporate proxy and need to proxy both Sauce Labs API calls as well as calls to the Selenium endpoint (ondemand.saucelabs.com) both sauceProxy/sauceAgent and webDriverProxy need to be used.