ts2.1: rearrange type translation, use new ObjectFlags #311
Conversation
|
Note: it's still intentional that the tests don't pass. |
| case ts.TypeFlags.EnumLiteral: | ||
| return 'number'; | ||
| case ts.TypeFlags.ESSymbol: | ||
| // NOTE: currently this is just a typedef for {?}, shrug. |
There was a problem hiding this comment.
| case ts.TypeFlags.NumberLiteral: | ||
| return 'number'; | ||
| case ts.TypeFlags.Never: | ||
| this.warn(`should not emit a 'never' type`); |
There was a problem hiding this comment.
why warning here? I think there are valid programs with the never type. Like users that mistrust the type system and want to augment it with a runtime check
switch (x)
default:
throw Error(x as any) <- x could be never here
There was a problem hiding this comment.
The question is what we want to do when we hit one of these. E.g. if you accidentally make an array of never, what type do we emit for Closure?
These warnings are never shown to a user and only show up inside the test suite, so it's probably harmless to leave it in... (?)
There was a problem hiding this comment.
So it is for inexpressible concepts in Closure. Makes sense, maybe StringLiterals and etc *Literals should also get a warning then? No need to take care in the cl.
| let isTuple = true; | ||
| // For unknown reasons, tuple types can be reference types containing a | ||
| // reference loop. see Destructuring3 in functions.ts. | ||
| // TODO(rado): handle tuples in their own branch. |
There was a problem hiding this comment.
thanks for taking care of my todo :)
There was a problem hiding this comment.
It's not done yet! There's an empty spot where tuples need to be handled. :P
Make the main "translate" function match the enum in the TypeScript API. Split out the handling of more complex Object types into a separate function, and adjust the code there to use the new objectFlags field. This actually makes most tests pass(!) but there are still a few more to track down, and there are still a bunch of TODOs. More work on #295.
Make the main "translate" function match the enum in the TypeScript API. Split out the handling of more complex Object types into a separate function, and adjust the code there to use the new objectFlags field. This actually makes most tests pass(!) but there are still a few more to track down, and there are still a bunch of TODOs. More work on #295.
Make the main "translate" function match the enum in the
TypeScript API. Split out the handling of more complex
Object types into a separate function, and adjust the code
there to use the new objectFlags field.
This actually makes most tests pass(!) but there are still
a few more to track down, and there are still a bunch of
TODOs.
More work on #295.