build: use NPM to install node_modules #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayazhafiz
approved these changes
Dec 4, 2020
atscott
approved these changes
Dec 7, 2020
`semver` is a prod dependency of `vscode-languageclient`. In the old build pipeline, `vscode-languageclient` is declared in `client/package.json`. When yarn installs dependencies in the `client` directory, it will put `semver` next to `vscode-languageclient` in `client/node_modules`. In the new build pipeline, `vscode-languageclient` is declared in root `package.json`. When yarn installs dependencies in the root directory, it chooses not to hoist `semver`, instead puts it in a nested node_modules under `node_modules/vscode-languageclient/node_modules`. There is a bug in vsce that causes it to ignore nested `node_modules`, resulting in a `vsix` build that is broken. The issue is trackeed [here](microsoft/vscode-vsce#432), but it does not look like a fix will come any time soon. For now we should install our dependencies using NPM.
kyliau
force-pushed
the
install-using-npm
branch
from
8f7816f
to
d79df2e
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
semveris a prod dependency ofvscode-languageclient.In the old build pipeline,
vscode-languageclientis declared inclient/package.json.When yarn installs dependencies in the
clientdirectory, it will putsemvernext to
vscode-languageclientinclient/node_modules.In the new build pipeline,
vscode-languageclientis declared in rootpackage.json.When yarn installs dependencies in the root directory, it chooses not to hoist
semver, instead puts it in a nested node_modules undernode_modules/vscode-languageclient/node_modules.There is a bug in vsce that causes it to ignore nested
node_modules,resulting in a
vsixbuild that is broken. The issue is trackedhere, but it does not look like a fix will come any time soon.
For now we should install our dependencies using NPM.