Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update screenshots in README #1017

Merged
merged 6 commits into from
Mar 10, 2021

Conversation

heyanurag
Copy link
Contributor

Description

Include a summary of the change and relevant motivation/context. List any dependencies that are required for this change.

Fixes #758

Type of Change:

Delete irrelevant options.

  • Documentation

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Describe the tests you ran to verify your changes. Provide instructions or GIFs so we can reproduce. List any relevant details for your test.

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged
  • I have written Kotlin Docs whenever is applicable

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@heyanurag
Copy link
Contributor Author

heyanurag commented Oct 13, 2020

the changes are visible here
@vj-codes @aditmehta9 @sanchi0204 When will the PR be reviewed?

anna4j
anna4j previously approved these changes Oct 15, 2020
@anna4j anna4j added the Status: Needs Review PR needs an additional review or a maintainer's review. label Oct 15, 2020
sanchi0204
sanchi0204 previously approved these changes Oct 15, 2020
@sanchi0204 sanchi0204 added Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Oct 15, 2020
Copy link
Member

@isabelcosta isabelcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@singhanurag05 could you please upload these images in a comment and then use instead the link of the URLs on the README? In this way, we can remove the binary files from the repository. Having these binary files adds unnecessary weight to this repository.

Here's a guide if you have any doubt on how to upload the images: https://gist.github.com/vinkla/dca76249ba6b73c5dd66a4e986df4c8d

@vj-codes vj-codes added Status: Changes Requested Changes are required to be done by the PR author. and removed Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. labels Oct 20, 2020
@heyanurag
Copy link
Contributor Author

I'll be doing this on the 7th of November as I have my mid semester exams starting tomorrow. Would that be fine?

@sanchi0204
Copy link
Contributor

I'll be doing this on the 7th of November as I have my mid semester exams starting tomorrow. Would that be fine?
@singhanurag05 pls update this PR as per the changes requested

@isabelcosta
Copy link
Member

@singhanurag05 are you still going to work on this issue? It is ok if not, we just need to know for triaging issues and pull requests purposes

@heyanurag
Copy link
Contributor Author

I currently wont be able to complete this. Going through a rough patch in life. really sorry for holding stuff up for this long

@aditmehta9
Copy link
Member

@singhanurag05 can you update the PR?

@heyanurag
Copy link
Contributor Author

yes sure!

@heyanurag
Copy link
Contributor Author

About Page
Change Password Page
Edit Profile Page
Filter Members Page
Home Page
Introduction Slider
Login Page
Member Profile Page
Members Page
Profile Page
Relations Page
Requests Page
Send Request Page
Settings Page
SignUp Screen
Splashscreen
Tasks Page

uploaded photos in a github comment (anitab-org#1017 (comment)) and added the image urls in the readme so that the screenshots folder could be removed from the repo.
@heyanurag heyanurag dismissed stale reviews from sanchi0204 and anna4j via f45107e February 15, 2021 14:08
@heyanurag
Copy link
Contributor Author

@aditmehta9 @isabelcosta I have made the changes please check.

@aditmehta9
Copy link
Member

@vj-codes can you review this?

aditmehta9
aditmehta9 previously approved these changes Feb 15, 2021
Copy link
Member

@aditmehta9 aditmehta9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vj-codes
Copy link
Member

@singhanurag05 could you please upload these images in a comment and then use instead the link of the URLs on the README? In this way, we can remove the binary files from the repository. Having these binary files adds unnecessary weight to this repository.

Here's a guide if you have any doubt on how to upload the images: https://gist.github.com/vinkla/dca76249ba6b73c5dd66a4e986df4c8d

@singhanurag05 hey almost done but as mentioned above you will need to remove the binary files as well from the PR.
This will also lead to removing the Screenshots folder from the repo as they are unnecessary weightage please update acc to this and so it'll just be one file changed (reamde) instead of 31 files in your PR and squash your commits if possible.
That's it and then it's good to merge, @aditmehta9 agree?

@aditmehta9
Copy link
Member

@singhanurag05 could you please upload these images in a comment and then use instead the link of the URLs on the README? In this way, we can remove the binary files from the repository. Having these binary files adds unnecessary weight to this repository.
Here's a guide if you have any doubt on how to upload the images: https://gist.github.com/vinkla/dca76249ba6b73c5dd66a4e986df4c8d

@singhanurag05 hey almost done but as mentioned above you will need to remove the binary files as well from the PR.
This will also lead to removing the Screenshots folder from the repo as they are unnecessary weightage please update acc to this and so it'll just be one file changed (reamde) instead of 31 files in your PR and squash your commits if possible.
That's it and then it's good to merge, @aditmehta9 agree?

Ohh yes I agree I didn't notice that.

@heyanurag
Copy link
Contributor Author

i cant figure out how to squash commits but I think someone who is able to merge the pr can squash the commits

@vj-codes
Copy link
Member

@aditmehta9 can you review this again please?

@vj-codes vj-codes added Status: Needs Review PR needs an additional review or a maintainer's review. and removed Status: Changes Requested Changes are required to be done by the PR author. labels Feb 16, 2021
@aditmehta9
Copy link
Member

@aditmehta9 can you review this again please?

Yes, sure, I just noticed that there isn't splash screen screenshot in this PR is it ok? Should I approve this PR?

@vj-codes
Copy link
Member

@aditmehta9 there's no splash screen currently for the apk

@aditmehta9
Copy link
Member

@aditmehta9 there's no splash screen currently for the apk

Ok thanks

@aditmehta9 aditmehta9 requested a review from vj-codes February 16, 2021 20:42
Copy link
Member

@vj-codes vj-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
@singhanurag05 thank you for making the changes:)

@vj-codes vj-codes added Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Feb 16, 2021
@vj-codes
Copy link
Member

Adding label ready to merge since it's documentation change

@aditmehta9
Copy link
Member

Tested after changes:

bandicam.2021-02-17.03-25-41-216.mp4

@heyanurag
Copy link
Contributor Author

i have changed my username to @heyanurag so please tag me there if there are further changes

@isabelcosta isabelcosta merged commit fadb36f into anitab-org:develop Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace the existing screenshots with the newly updated layout screenshots in the Readme.md file
6 participants