Export Svelte internals #1340
Merged
Export Svelte internals #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Means add-on authors should not need to inject any code in their build - Should be more flexible - we can export multiple libraries if we wish, and don't have to worry about require() being clobbered by old add-ons.
|
Thanks Henrik, feeling much more positive about this now. By moving the require definition into Anki, we'll gain more flexibility, and it will mean the only thing required on the add-on end is to mark svelte as external: hgiesel/anki_new_format_pack@ff41a9c |
This was referenced Aug 24, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of what you suggested in #1327 and it works very well.
This increases the amount of setup for add-ons a little bit, but it's the solution we want. Maybe the
svelte-shim.jsfile could also be packaged with npm. I'll look into that (probably in a week though, as I won't be online much next week).I've setup New Format Pack with this version here.