Skip to content

feat(trace): Disabled otlp-grpc block mode #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025
Merged

feat(trace): Disabled otlp-grpc block mode #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion trace/otlp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ func NewOtlpGrpcClientConnection(ctx context.Context, host string, dialOptions .

dialContextOptions := []grpc.DialOption{
grpc.WithTransportCredentials(insecure.NewCredentials()),
grpc.WithBlock(),
}

dialContextOptions = append(dialContextOptions, dialOptions...)
Expand Down
7 changes: 6 additions & 1 deletion trace/otlp_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ func TestNewOtlpGrpcInsecureConnectionSuccess(t *testing.T) {
context.Background(),
"bufnet",
grpc.WithContextDialer(bufDialer),
grpc.WithBlock(),
)
assert.NoError(t, err)

Expand All @@ -51,7 +52,11 @@ func TestNewOtlpGrpcInsecureConnectionError(t *testing.T) {
ctx, cancel := context.WithDeadline(context.Background(), time.Now().Add(1*time.Microsecond))
defer cancel()

_, err := trace.NewOtlpGrpcClientConnection(ctx, "https://example.com")
_, err := trace.NewOtlpGrpcClientConnection(
ctx,
"https://example.com",
grpc.WithBlock(),
)
assert.Error(t, err)
assert.Contains(t, err.Error(), "context deadline exceeded")
}
Loading