From 593e9edaa9e776db35b3bedfa942c015d7b1e4af Mon Sep 17 00:00:00 2001 From: Eugene Burkov Date: Thu, 7 Dec 2023 16:45:10 +0300 Subject: [PATCH] dhcpsvc: imp docs --- internal/dhcpsvc/v6.go | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/internal/dhcpsvc/v6.go b/internal/dhcpsvc/v6.go index 457785aef91..b74a5afbc35 100644 --- a/internal/dhcpsvc/v6.go +++ b/internal/dhcpsvc/v6.go @@ -62,7 +62,7 @@ type iface6 struct { // name is the name of the interface. name string - // implicitOpts are the options listed in Appendix A of RFC 2131 and + // implicitOpts are the DHCPv6 options listed in RFC 8415 (and others) and // initialized with default values. It must not have intersections with // explicitOpts. implicitOpts layers.DHCPv6Options @@ -106,15 +106,12 @@ func newIface6(name string, conf *IPv6Config) (i *iface6) { // options returns the implicit and explicit options for the interface. The two // lists are disjoint and the implicit options are initialized with default // values. +// +// TODO(e.burkov): Add implicit options according to RFC. func (conf *IPv6Config) options() (implicit, explicit layers.DHCPv6Options) { - // Set default values of host configuration parameters listed in Appendix A - // of RFC-2131. Keep the list sorted by option code for using the binary - // search. - implicit = layers.DHCPv6Options{ - // Values From Configuration - - // TODO(e.burkov): Add implicit options according to RFC. - } + // Set default values of host configuration parameters listed in RFC 8415. + // Keep the list sorted by option code for using the binary search. + implicit = layers.DHCPv6Options{} // Set values for explicitly configured options. for _, exp := range conf.Options {