Add Applicative trait
#115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmasrovira
force-pushed
the
applicative
branch
3 times, most recently
from
d79d29c to
076ff28
Compare
janmasrovira
force-pushed
the
applicative
branch
from
076ff28 to
bc030a0
Compare
janmasrovira
force-pushed
the
applicative
branch
from
161e715 to
e11e41d
Compare
|
Can we merge this after the following PRs? Otherwise we'd have to do another round of updating the juvix-stldib ref in main of juvix and rebasing. |
janmasrovira
force-pushed
the
applicative
branch
2 times, most recently
from
581c12a to
132a0c6
Compare
Merged
janmasrovira
force-pushed
the
applicative
branch
2 times, most recently
from
ea4faec to
d8da355
Compare
paulcadman
reviewed
Aug 5, 2024
Comment on lines
-11
to
12
| import Stdlib.Trait.Functor open; | ||
| import Stdlib.Trait open; | ||
| import Stdlib.Trait.Partial open; |
There was a problem hiding this comment.
If you use import Stdlib.Trait open are the other Trait imports redundant?
paulcadman
reviewed
Aug 5, 2024
Comment on lines
7
to
+8
| import Stdlib.Trait.Ord open; | ||
| import Stdlib.Trait.Functor open; | ||
| import Stdlib.Trait open; |
There was a problem hiding this comment.
If you use import Stdlib.Trait open are the other Trait imports redundant?
paulcadman
force-pushed
the
applicative
branch
from
2314178 to
0ca2d51
Compare
paulcadman
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicativetrait.List,Maybe,Result.