-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to Ghc 9.8.1 #2624
Merged
Merged
upgrade to Ghc 9.8.1 #2624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmasrovira
force-pushed
the
ghc-9.8.1
branch
from
February 6, 2024 14:47
62bfbe5
to
15c0685
Compare
paulcadman
approved these changes
Feb 7, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the stackage LTS resolver to
nightly-2024-02-06
which uses GHC 9.8.1Upgrade notes
You will need to update your HLS to 2.6.0.0, this release contains support for GHC 9.8.1
Fixes
haskeline
/repline
We have removed the custom haskeline / repline forks used in the build. This is because we had trouble overriding haskeline as it is bundled with GHC and the stackage resolver uses this bundled version. We were using a custom fork of haskeline to implement mapInputT_ in the Juvix REPL, required to implement error handling. This requires private API from the Haskeline library.
Instead of using a custom fork we use TemplateHaskell to obtain access to the private API we need. See DarkArts.hs and HaskelineJB.hs.
To obtain access to the private API, we adapted a method from a Tweag blogpost and repo - updating it for GHC 9.8.1.
aeson-better-errors
The
aeson-better-errors
library has not been updated to work withmtl-2.3.0
so it cannot work with the new stackage resolver. We are using a fork which has been updated.We should consider replacing this library in future, see #2621
path
The
path
library now includes APIsplitDrive
anddropDrive
so we can remove our versions of those functions from the prelude.with-utf8
We no longer need to depend on
with-utf8
. We were using this package for UTF-8 versions ofreadFile
andwriteFile
APIs. These APIs are now available in thetext
package.Compiler warnings
GHC 9.8.1 introduces several new compiler warnings.
missing-role-annotations
andmissing-poly-kind-signatures
head
andtail
to work around the newpartial-tx
warning introduced for those functions inData.List
.