Use the target of aliases when resolving name signatures and iterators #2669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcadman
force-pushed
the
alias-record-constructor-bug
branch
from
b41ccfd to
6d6dce8
Compare
lukaszcz
force-pushed
the
alias-record-constructor-bug
branch
from
6d6dce8 to
c4c1690
Compare
scopedIdenSrcName refers to the name of an identifier from the source code. The name `scopedIdenName` is confusing because users of `ScopedIden` may think that this lens refers to the only name associated with ScopedIden, they may want scopedIdenNameFinal instead.
lukaszcz
force-pushed
the
alias-record-constructor-bug
branch
from
c4c1690 to
477c801
Compare
lukaszcz
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As well as this fix we rename lens scopedIdenName to scopedIdenSrcName.
scopedIdenSrcNamerefers to the name of an identifier from the source code. The namescopedIdenNameis confusing because users ofScopedIdenmay think that this lens refers to the only name associated withScopedIden, they may wantscopedIdenNameFinalinstead.