Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline immediate values #2842

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Inline immediate values #2842

merged 1 commit into from
Jun 20, 2024

Conversation

lukaszcz
Copy link
Collaborator

@lukaszcz lukaszcz commented Jun 19, 2024 •
edited
Loading

  • Closes Inlining doesn't always work #2745
  • Adds inlining of immediate values, i.e., values that don't require computation or memory allocation.
  • Non-immediate zero-argument functions / values should not be inlined, because when not inlined they can be computed only once.

@lukaszcz lukaszcz added enhancement New feature or request core Related to JuvixCore optimization labels Jun 19, 2024
@lukaszcz lukaszcz added this to the 0.6.3 milestone Jun 19, 2024
@lukaszcz lukaszcz self-assigned this Jun 19, 2024
@lukaszcz lukaszcz force-pushed the inline-immediate branch 2 times, most recently from 375e768 to 3805892 Compare June 20, 2024 10:04
@lukaszcz lukaszcz merged commit af758cc into main Jun 20, 2024
4 checks passed
@lukaszcz lukaszcz deleted the inline-immediate branch June 20, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcadman paulcadman paulcadman approved these changes

@janmasrovira janmasrovira Awaiting requested review from janmasrovira

Assignees

@lukaszcz lukaszcz

Labels
core Related to JuvixCore enhancement New feature or request optimization
Projects
None yet
Milestone
0.6.3
Development

Successfully merging this pull request may close these issues.

Inlining doesn't always work
2 participants
@lukaszcz @paulcadman