Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow instance field declarations #2916

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Allow instance field declarations #2916

merged 5 commits into from
Jul 29, 2024

Conversation

janmasrovira
Copy link
Collaborator

@janmasrovira janmasrovira commented Jul 25, 2024 •
edited
Loading

@janmasrovira janmasrovira self-assigned this Jul 25, 2024
@janmasrovira janmasrovira linked an issue Jul 25, 2024 that may be closed by this pull request
Allow instance field declarations #2897
Closed
@janmasrovira janmasrovira force-pushed the 2897-allow-instance-field-declarations branch from 9691b0a to 833117f Compare July 25, 2024 13:06
@janmasrovira janmasrovira force-pushed the 2897-allow-instance-field-declarations branch from 6971cef to 8e74f4b Compare July 26, 2024 13:24
@janmasrovira janmasrovira marked this pull request as ready for review July 29, 2024 08:07
@janmasrovira janmasrovira requested a review from lukaszcz July 29, 2024 08:11
@janmasrovira janmasrovira requested a review from paulcadman July 29, 2024 12:54
@lukaszcz
Copy link
Collaborator

Does this PR fully close the issue, or is this partial implementation?

I don't see the test Internal/InstanceFields.juvix used anywhere - it seems it's not actually executed by the test suite. And we should also have an end-to-end test in the compilation pipeline tests.

@janmasrovira janmasrovira merged commit 1e9850c into main Jul 29, 2024
4 checks passed
@janmasrovira janmasrovira deleted the 2897-allow-instance-field-declarations branch July 29, 2024 16:44
@lukaszcz lukaszcz mentioned this pull request Jul 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcadman paulcadman paulcadman approved these changes

@lukaszcz lukaszcz Awaiting requested review from lukaszcz

Assignees

@janmasrovira janmasrovira

Labels
enhancement New feature or request traits typechecking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow instance field declarations
3 participants
@janmasrovira @lukaszcz @paulcadman