bugfix: postgres_info.py now shows the info of each specific database

[marcosdiez]

SUMMARY

fixes #172

The reason postgres_info.py was gathering data on every database was because of a bug in PgDbConn.reconnect(), which is fixed here.

I also changed the main loop that iterate among all DBs to ignore DBs which it can't access because in AWS RDS not all DBs are accessible.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

postgres_info.py

[Andersson007]

@marcosdiez hi and welcome to the project! Thank you for the bunch of issues and fixes! Could you please:

• Make CI green
• Add a changelog fragment to each PRs https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment
• Add integration tests (where possible). See the content of tests/integration/target/postgresql_info/tasks

[Andersson007]

@marcosdiez thank you for the PR, could you please:

1. Fix CI, everything should be green (see the "Details" link for details)
2. Be sure the changes is covered with integration tests, see the content of tests/integration/targets/postgresql_info/tasks

[Andersson007]

closed reopened to re-trigger CI

[Andersson007]

@marcosdiez ah, the failings are unrelated (there are AZP issues there), sorry
So please cover the case mentioned in #172 somewhere within tests/integration/targets/postgresql_info/tasks and let us know when it's ready for review (if you need any help, just ask)

[marcosdiez]

@Andersson007 hi! Unit tests added. Sorry for the delay, but it took me longer to find out how to run unit tests locally then to actually write them.

By the way, the solution I found is time ansible-test integration --target docker:ubuntu2004 --docker-terminate never -v postgresql_info which is taking a little more than a minute on each iteration.

I still have not found a way to use the same container and hence not have to download postgres every time I want to run unit tests.

Please feel free to core review this PR and request changes as needed.
Thanks!

[Andersson007]

LGTM

[Andersson007]

@marcosdiez thanks for the great contribution!:)

[Andersson007]

By the way, the solution I found is time ansible-test integration --target docker:ubuntu2004 --docker-terminate never -v postgresql_info which is taking a little more than a minute on each iteration.

I just use ansible-test integration postgresql_info --docker ubuntu2004 -vvv > ~/test.log, never dug into it deeply. I'll compare your command with this simplest one next time, thank you!