-
Notifications
You must be signed in to change notification settings - Fork 23.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AnsibleContext and hostvars to preserve unsafe #84299
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CVE-2024-11079 Also fix hostvars to present implicit localhost to AnsibleContext when vars are present
ansibot
added
bug
This issue/PR relates to a bug.
needs_triage
Needs a first human triage before being processed.
labels
Nov 12, 2024
mkrizek
removed
the
needs_triage
Needs a first human triage before being processed.
label
Nov 12, 2024
ansibot
added
the
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
label
Nov 12, 2024
added more coverage/comments/block scope
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
when a single var contianed is unsafe
fix tests
webknjaz
added
the
ci_verified
Changes made in this PR are causing tests to fail.
label
Nov 13, 2024
ansibot
removed
the
ci_verified
Changes made in this PR are causing tests to fail.
label
Nov 14, 2024
webknjaz
added
the
ci_verified
Changes made in this PR are causing tests to fail.
label
Nov 14, 2024
jborean93
reviewed
Nov 15, 2024
jborean93
reviewed
Nov 15, 2024
closed in favor of #84339 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bug
This issue/PR relates to a bug.
ci_verified
Changes made in this PR are causing tests to fail.
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CVE-2024-11079
Also fix hostvars to present implicit localhost to AnsibleContext when vars are present
ISSUE TYPE