Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHORE: Clean up template file #5547

Merged
merged 1 commit into from
Dec 10, 2024
Merged

CHORE: Clean up template file #5547

merged 1 commit into from
Dec 10, 2024

Conversation

SMoraisAnsys
Copy link
Collaborator

Description

A template file got introduced by mistake while doing the changes with AEDT 24.2
Probably a file resulting from example / extension testing.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, was it creating any problem with our CI?
Probably no, but just checking some workflows behavior.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.75%. Comparing base (4e678aa) to head (8650c11).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5547      +/-   ##
==========================================
+ Coverage   79.39%   84.75%   +5.35%     
==========================================
  Files         144      144              
  Lines       60199    60199              
==========================================
+ Hits        47798    51021    +3223     
+ Misses      12401     9178    -3223     

@SMoraisAnsys SMoraisAnsys enabled auto-merge (squash) December 9, 2024 13:48
@SMoraisAnsys
Copy link
Collaborator Author

Out of curiosity, was it creating any problem with our CI? Probably no, but just checking some workflows behavior.

It does not create any problem, I was looking at our pyproject.toml file and fell on the file by mistake. It seems that I added it months ago while doing the migration to AEDT 24.2 and it's probable a left over of running some examples or extensions

@SMoraisAnsys SMoraisAnsys merged commit 30cc29f into main Dec 10, 2024
43 checks passed
@SMoraisAnsys SMoraisAnsys deleted the chore/clean-up-repository branch December 10, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants