added components to NS

reverted changes to move_translate

Author: jacobrkerstetter

src/ansys/geometry/core/designer/design.py

@@ -607,6 +607,7 @@ def create_named_selection(
         edges: list[Edge] | None = None,
         beams: list[Beam] | None = None,
         design_points: list[DesignPoint] | None = None,
+        components: list[Component] | None = None,
     ) -> NamedSelection:
         """Create a named selection on the active Geometry server instance.
 
@@ -624,6 +625,8 @@ def create_named_selection(
             All beams to include in the named selection.
         design_points : list[DesignPoint], default: None
             All design points to include in the named selection.
+        components : list[Component], default: None
+            All components to include in the named selection.
 
         Returns
         -------
@@ -637,10 +640,10 @@ def create_named_selection(
             one of the optional parameters must be provided.
         """
         # Verify that at least one entity is provided
-        if not any([bodies, faces, edges, beams, design_points]):
+        if not any([bodies, faces, edges, beams, design_points, components]):
             raise ValueError(
                 "At least one of the following must be provided: "
-                "bodies, faces, edges, beams, or design_points."
+                "bodies, faces, edges, beams, design_points, or components."
             )
 
         named_selection = NamedSelection(
@@ -652,6 +655,7 @@ def create_named_selection(
             edges=edges,
             beams=beams,
             design_points=design_points,
+            components=components,
         )
 
         self._named_selections[named_selection.name] = named_selection

src/ansys/geometry/core/designer/geometry_commands.py

@@ -1308,16 +1308,16 @@ def get_round_info(self, face: "Face") -> tuple[bool, Real]:
     @min_backend_version(25, 2, 0)
     def move_translate(
         self,
-        selection: NamedSelection | Component,
+        selection: NamedSelection,
         direction: UnitVector3D,
         distance: Distance | Quantity | Real,
     ) -> bool:
         """Move a selection by a distance in a direction.
 
         Parameters
         ----------
-        selection : NamedSelection | Component
-            Named selection or component to move.
+        selection : NamedSelection
+            Named selection to move.
         direction : UnitVector3D
             Direction to move in.
         distance : Distance | Quantity | Real

src/ansys/geometry/core/designer/selection.py

@@ -27,12 +27,14 @@
 from ansys.geometry.core.connection.conversions import grpc_point_to_point3d
 from ansys.geometry.core.designer.beam import Beam
 from ansys.geometry.core.designer.body import Body
+from ansys.geometry.core.designer.component import Component
 from ansys.geometry.core.designer.designpoint import DesignPoint
 from ansys.geometry.core.designer.edge import Edge
 from ansys.geometry.core.designer.face import Face
 from ansys.geometry.core.misc.auxiliary import (
     get_beams_from_ids,
     get_bodies_from_ids,
+    get_components_from_ids,
     get_edges_from_ids,
     get_faces_from_ids,
 )
@@ -67,6 +69,8 @@ class NamedSelection:
         All beams to include in the named selection.
     design_points : list[DesignPoints], default: None
         All design points to include in the named selection.
+    components: list[Component], default: None
+        All components to include in the named selection.
     """
 
     def __init__(
@@ -79,6 +83,7 @@ def __init__(
         edges: list[Edge] | None = None,
         beams: list[Beam] | None = None,
         design_points: list[DesignPoint] | None = None,
+        components: list[Component] | None = None,
         preexisting_id: str | None = None,
     ):
         """Initialize the ``NamedSelection`` class."""
@@ -97,13 +102,16 @@ def __init__(
             beams = []
         if design_points is None:
             design_points = []
+        if components is None:
+            components = []
 
         # Instantiate
         self._bodies = bodies
         self._faces = faces
         self._edges = edges
         self._beams = beams
         self._design_points = design_points
+        self._components = components
 
         # Store ids for later use... when verifying if the NS changed.
         self._ids_cached = {
@@ -112,6 +120,7 @@ def __init__(
             "edges": [edge.id for edge in edges],
             "beams": [beam.id for beam in beams],
             "design_points": [dp.id for dp in design_points],
+            "components": [component.id for component in components],
         }
 
         if preexisting_id:
@@ -193,6 +202,16 @@ def design_points(self) -> list[DesignPoint]:
             ]
 
         return self._design_points
+    
+    @property
+    def components(self) -> list[Component]:
+        """All components in the named selection."""
+        self.__verify_ns()
+        if self._components is None:
+            # Get all components from the named selection
+            self._components = get_components_from_ids(self._design, self._ids_cached["components"])
+
+        return self._components
 
     def __verify_ns(self) -> None:
         """Verify that the contents of the named selection are up to date."""

src/ansys/geometry/core/misc/auxiliary.py

@@ -183,6 +183,30 @@ def get_bodies_from_ids(design: "Design", body_ids: list[str]) -> list["Body"]:
     return [body for body in __traverse_all_bodies(design) if body.id in body_ids]
 
 
+def get_components_from_ids(design: "Design", component_ids: list[str]) -> list["Component"]:
+    """Find the ``Component`` objects inside a ``Design`` from its ids.
+
+    Parameters
+    ----------
+    design : Design
+        Parent design for the components.
+    component_ids : list[str]
+        List of component ids.
+
+    Returns
+    -------
+    list[Component]
+        List of Component objects.
+
+    Notes
+    -----
+    This method takes a design and component ids, and gets their corresponding ``Component`` object.
+    """
+    return [
+        comp for comp in __traverse_component_elem("components", design) if comp.id in component_ids
+    ]  # noqa: E501
+
+
 def get_faces_from_ids(design: "Design", face_ids: list[str]) -> list["Face"]:
     """Find the ``Face`` objects inside a ``Design`` from its ids.
 

tests/integration/test_geometry_commands.py

@@ -1186,9 +1186,12 @@ def test_move_translate_component(modeler: Modeler):
     sketch = Sketch().box(Point2D([0, 0]), 1, 1)
     box_body = component.extrude_sketch("BoxBody", sketch, 1)
 
+    # Add the component to a named selection
+    ns = design.create_named_selection("ComponentNS", components=[component])
+
     # Move the component
     success = modeler.geometry_commands.move_translate(
-        component,
+        ns,
         UNITVECTOR3D_Z,
         Distance(2, UNITS.m),
     )