Skip to content

Commit 37fa99e

Browse files
PipKatclatapieRobPasMue
authored
Edits for doc review before public release (#69)
Co-authored-by: Camille <78221213+clatapie@users.noreply.github.com> Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
1 parent e9d087a commit 37fa99e

File tree

13 files changed

+514
-362
lines changed

13 files changed

+514
-362
lines changed

.github/workflows/ci_cd.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -307,6 +307,7 @@ jobs:
307307
checkout: false
308308
skip-install: true
309309
sphinxopts: -j auto
310+
requires-xvfb: true
310311

311312

312313
package:

README.rst

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ PyAnsys Math
3030
PyAnsys Math is a Python repository holding Ansys mathematical libraries.
3131
To use them, you must have a local installation of Ansys Mechanical APDL.
3232

33-
For more information on getting a licensed copy of Ansys Mechanical APDL, visit
34-
the `Ansys web site <https://www.ansys.com/>`_ .
33+
For information on getting a licensed copy of Ansys Mechanical APDL, visit
34+
the `Ansys web site <https://www.ansys.com/>`_.
3535

3636

3737

@@ -43,12 +43,15 @@ For users
4343
The ``ansys.math.core`` package currently supports Python 3.7 through
4444
Python 3.10 on Windows, Mac OS, and Linux.
4545

46+
Install the latest package for use with this command:
47+
4648
.. code::
4749
4850
pip install ansys-math-core
4951
50-
Alternatively, install the latest from
51-
`PyAnsys Math GitHub <https://github.com/pyansys/pyansys-math.git>`_ via:
52+
Alternatively, install the latest
53+
`PyAnsys Math GitHub <https://github.com/pyansys/pyansys-math.git>`_ package
54+
with this command:
5255

5356
.. code::
5457
@@ -58,16 +61,17 @@ Alternatively, install the latest from
5861
5962
For developers
6063
~~~~~~~~~~~~~~
61-
For a local *development* version, install with:
64+
For a local *development* version, install the latest package with:
6265

6366
.. code::
6467
6568
git clone https://github.com/pyansys/pyansys-math.git
6669
cd pyansys-math
6770
pip install -e .
6871
69-
This allows you to install and edit the ``ansys-math-core`` module locally.
70-
The changes that you make are reflected in your setup
72+
73+
Installing the development version allows you to edit the ``ansys-math-core``
74+
package locally. The changes that you make are reflected in your setup
7175
after restarting the Python kernel.
7276

7377

@@ -85,8 +89,8 @@ Check that you can start PyAnsys Math from Python by running this code:
8589
print(mm)
8690
8791
88-
If you see a response from the server, congratulations. You're ready
89-
to start using PyAnsys Math as a service.
92+
If you see a response from the server, you can start using PyAnsys Math
93+
as a service.
9094

9195
Ansys software requirements
9296
---------------------------

doc/source/contributing/index.rst

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
.. _ref_contributing:
22

3-
Contributing
4-
============
3+
Contribute
4+
==========
55

66
Overall guidance on contributing to a PyAnsys library appears in the
77
`Contributing <dev_guide_contributing_>`_ topic
@@ -10,8 +10,8 @@ with this guide before attempting to contribute to PyAnsys Math.
1010

1111
The following contribution information is specific to PyAnsys Math.
1212

13-
Cloning the repository
14-
----------------------
13+
Clone the repository
14+
--------------------
1515

1616
Run this code to clone and install the latest version of PyAnsys Math in development mode::
1717

@@ -20,8 +20,8 @@ Run this code to clone and install the latest version of PyAnsys Math in develop
2020
python -m pip install --upgrade pip
2121
pip install -e .
2222

23-
Posting issues
24-
--------------
23+
Post issues
24+
-----------
2525

2626
Use the `PyAnsys Math Issues <pymath_issues_>`_ page to submit questions,
2727
report bugs, and request new features. When possible, use these issue
@@ -35,8 +35,8 @@ If your issue does not fit into one of these categories, create your own issue.
3535
To reach the PyAnsys support team, email `pyansys.support@ansys.com <pyansys_support_>`_.
3636

3737

38-
Building documentation
39-
----------------------
38+
Build documentation
39+
-------------------
4040

4141
To build the PyAnsys Math documentation locally, in the root directory of the repository, run::
4242
@@ -52,8 +52,8 @@ Documentation for the latest development version, which tracks the
5252
This version is automatically kept up to date via GitHub actions.
5353

5454

55-
Code style
56-
----------
55+
Adhere to code style
56+
--------------------
5757

5858
PyAnsys Math follows the PEP8 standard as outlined in the `PyAnsys Development Guide
5959
<dev_guide_pyansys_>`_ and implements style checking using
@@ -68,7 +68,7 @@ You can also install this as a pre-commit hook by running this code::
6868

6969
pre-commit install
7070

71-
This way, it's not possible for you to push code that fails the style checks. For example::
71+
This way, it's not possible for you to push code that fails the style checks::
7272

7373
$ pre-commit install
7474
$ git commit -am "added my cool feature"

doc/source/index.rst

Lines changed: 22 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -5,34 +5,33 @@ PyAnsys Math documentation
55
Introduction
66
------------
77

8-
PyAnsys Math aims to gather all the mathematical calculation tools present
9-
in the Ansys software.
8+
PyAnsys Math aims to gather all mathematical calculation tools present
9+
in Ansys software.
1010

11-
This library provides the ability to access and manipulate large
12-
sparse matrices and solve a variety of eigenproblems. It is presented in a
13-
similar manner to the popular `NumPy <numpy_docs_>`_ and
14-
`SciPy <scipy_docs_>`_ libraries.
11+
This Python library allows you to access and manipulate large sparse matrices
12+
and solve a variety of eigenproblems. It is presented in a similar manner to
13+
the popular `NumPy <numpy_docs_>`_ and `SciPy <scipy_docs_>`_ libraries.
1514

16-
The PyAnsys Math command set is based on tools for manipulating large mathematical
15+
The command set for PyAnsys Math is based on tools for manipulating large mathematical
1716
matrices and vectors that provide access to standard linear algebra operations and the
18-
powerful sparse linear solvers of Ansys Mechanical APDL, providing the ability to solve
19-
eigenproblems.
17+
powerful sparse linear solvers of Ansys Mechanical APDL (MAPDL), providing the ability
18+
to solve eigenproblems.
2019

2120
Python and MATLAB eigensolvers are based on the publicly available
22-
LAPACK libraries and provide reasonable solve time for eigenproblems
21+
LAPACK libraries and provide reasonable solve times for eigenproblems
2322
with relatively small degrees of freedom (DOF), perhaps 100,000.
2423
However, Ansys solvers are designed for the scale of hundreds of
2524
millions of DOF, providing a variety of situations where you can
2625
directly leverage Ansys high-performance solvers on a variety of
2726
eigenproblems. Fortunately, you can leverage this without relearning
2827
an entirely new language because PyAnsys Math is written in a similar manner
29-
as the ``NumPy`` and ``SciPy`` libraries. For example, here is a comparison between
28+
as the NumPy and SciPy libraries. For example, here is a comparison between
3029
the NumPy and SciPy linear algebra solvers and the PyAnsys Math solver:
3130

32-
.. table:: ``NumPy`` and ``SciPy`` vs ``PyAnsys Math`` implementation
31+
.. table:: NumPy and SciPy versus PyAnsys Math implementation
3332

3433
+--------------------------------------------+-----------------------------------+
35-
| ``NumPy`` and ``SciPy`` | ``PyAnsys Math`` |
34+
| NumPy and SciPy | PyAnsys Math |
3635
+============================================+===================================+
3736
| .. code:: python | .. code:: python |
3837
| | |
@@ -47,20 +46,16 @@ the NumPy and SciPy linear algebra solvers and the PyAnsys Math solver:
4746
Background
4847
----------
4948

50-
PyAnsys Math is a library using the Ansys Mechanical APDL (MAPDL) solver in the
51-
background.
49+
PyAnsys Math uses the MAPDL solver in the background. It is based on the
50+
``launch_mapdl()`` method from PyMAPDL's `ansys-mapdl-core <pymapdl_github_>`_
51+
package.
5252

53-
It is based on the ``launch_mapdl()`` method from the `ansys-mapdl-core
54-
<pymapdl_github_>`_ library. The latter uses `gRPC <grpc_>`_, which allows
55-
the MAPDL solver to function as a server, ready to respond to connecting
56-
clients.
57-
58-
Google Remote Procedure Calls, or gRPC, are used to establish secure
59-
connections so that a client app can directly call methods on
60-
a potentially remote MAPDL instance as if it were a local object. The
61-
use of HTTP/2 makes it friendly to modern internet infrastructures.
62-
This, along with the use of binary transmission formats, favors higher
63-
performance.
53+
Because PyMAPDL is `gRPC <grpc_>`_-based, the MAPDL solver can function as
54+
a server, ready to respond to connecting clients. With gRPC establishing
55+
secure connections, a client app can directly call methods on a potentially
56+
remote MAPDL instance as if it were a local object. The use of HTTP/2 makes
57+
gRPC friendly to modern internet infrastructures. This, along with the use
58+
of binary transmission formats, favors higher performance.
6459

6560

6661
Quick code
@@ -87,7 +82,7 @@ Here is a brief example of how you use PyAnsys Math:
8782
1.417e+00 1.997e+00 1.720e+00 1.933e+00 1.000e+00 < 5
8883
8984
90-
For additional PyAnsys Math examples, see :ref:`ref_pymath_examples`.
85+
For comprehensive PyAnsys Math examples, see :ref:`ref_pymath_examples`.
9186

9287

9388
.. toctree::

examples/README.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22

33
Examples
44
========
5-
These examples demonstrate using the PyAnsys Math library.
5+
These examples show how you use the PyAnsys Math library.

0 commit comments

Comments
 (0)