-
Notifications
You must be signed in to change notification settings - Fork 140
fix(launcher): relax stdout check for gRPC server startup #4299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Match "GRPC SERVER" (instead of the stricter "START GRPC SERVER") when detecting MAPDL's "Server listening on" output. This makes the startup detection more robust to variations in MAPDL log messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR relaxes the stdout check for gRPC server startup detection in the MAPDL launcher to improve robustness. The change makes the startup detection less strict by matching a shorter substring of the MAPDL log output.
- Modified the gRPC server detection pattern from "START GRPC SERVER" to "GRPC SERVER"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4299 +/- ##
==========================================
- Coverage 91.29% 91.18% -0.12%
==========================================
Files 193 193
Lines 15742 15742
==========================================
- Hits 14372 14354 -18
- Misses 1370 1388 +18 🚀 New features to boost your workflow:
|
|
I need this... sooo.. @pyansys-ci-bot LGTM. |
pyansys-ci-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Match "GRPC SERVER" (instead of the stricter "START GRPC SERVER") when
detecting MAPDL's "Server listening on" output. This makes the startup
detection more robust to variations in MAPDL log messages.
Description
Please provide a brief description of the changes made in this pull request.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)