Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 11, 2025

Match "GRPC SERVER" (instead of the stricter "START GRPC SERVER") when
detecting MAPDL's "Server listening on" output. This makes the startup
detection more robust to variations in MAPDL log messages.

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

Match "GRPC SERVER" (instead of the stricter "START GRPC SERVER") when
detecting MAPDL's "Server listening on" output. This makes the startup
detection more robust to variations in MAPDL log messages.
Copilot AI review requested due to automatic review settings November 11, 2025 22:58
@germa89 germa89 requested a review from a team as a code owner November 11, 2025 22:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR relaxes the stdout check for gRPC server startup detection in the MAPDL launcher to improve robustness. The change makes the startup detection less strict by matching a shorter substring of the MAPDL log output.

  • Modified the gRPC server detection pattern from "START GRPC SERVER" to "GRPC SERVER"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Nov 11, 2025
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.18%. Comparing base (e6ca79f) to head (fddee12).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4299      +/-   ##
==========================================
- Coverage   91.29%   91.18%   -0.12%     
==========================================
  Files         193      193              
  Lines       15742    15742              
==========================================
- Hits        14372    14354      -18     
- Misses       1370     1388      +18     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) labels Nov 12, 2025
@germa89
Copy link
Collaborator Author

germa89 commented Nov 12, 2025

I need this... sooo..

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 45ead1e into main Nov 12, 2025
46 of 48 checks passed
@germa89 germa89 deleted the fix/update-console-output-check branch November 12, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants