Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] Strict ts #3723

Merged
merged 14 commits into from
Mar 14, 2019
Merged

[v4] Strict ts #3723

merged 14 commits into from
Mar 14, 2019

Conversation

imhele
Copy link
Contributor

@imhele imhele commented Mar 11, 2019

@imhele imhele changed the title Strict ts [v4] Strict ts Mar 11, 2019
@netlify
Copy link

netlify bot commented Mar 11, 2019

Deploy preview for ant-design-pro ready!

Built with commit fe1ba24

https://deploy-preview-3723--ant-design-pro.netlify.com

@imhele imhele marked this pull request as ready for review March 12, 2019 18:32
className,
collapsed,
handleOpenChange,
style,
menuData,
} = this.props;
// if pathname can't match, use the nearest parent's key
let selectedKeys = this.getSelectedMenuKeys(pathname);
let selectedKeys = this.getSelectedMenuKeys(location!.pathname);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!.看起来很不舒服

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(location as Location).pathname 更不舒服😂

@xiaohuoni xiaohuoni merged commit 0bc812b into ant-design:v4 Mar 14, 2019
@imhele imhele deleted the strict-ts branch March 16, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants