feat: add deno as package manager #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
commented
Oct 31, 2024
Comment on lines
+64
to
+65
| 'upgrade': ['deno', 'update', 0], | ||
| 'upgrade-interactive': ['deno', 'update', 0], |
There was a problem hiding this comment.
This is actually not true yet, we plan to add these commands in Deno v2.1 later in November.
bartlomieju
commented
Oct 31, 2024
benmccann
approved these changes
Nov 1, 2024
userquin
approved these changes
Nov 14, 2024
benmccann
reviewed
Nov 18, 2024
| 'upgrade': ['deno', 'update', 0], | ||
| 'upgrade-interactive': ['deno', 'update', 0], | ||
| 'execute': ['deno', 'run', 0], | ||
| 'execute-local': ['deno', 'run', 0], |
There was a problem hiding this comment.
It looks like the same command is used here for execute and execute-local, which means this isn't working in in the Svelte CLI: sveltejs/cli#313 (review). Does Deno have some equivalent to pnpm exec or should we make a feature request for that?
There was a problem hiding this comment.
Ooops, my bad. We currently have no way to do it, so a feature request would be helpful. I think we could handle that with deno task --eval so it uses cross-platform shell.
There was a problem hiding this comment.
Okay, filed a request here: denoland/deno#26918
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Deno as a valid package manager recognized by
package-manager-detector.Linked Issues
Closes #21
Additional context
As of Deno v2.0.5, Deno will provide
npm_config_user_agentenv var in relevant subcommands (denoland/deno#26639).