Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for showing PURL and CPE in the summary table #4

Closed
alcroito opened this issue Jul 30, 2024 · 5 comments
Closed

Support for showing PURL and CPE in the summary table #4

alcroito opened this issue Jul 30, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@alcroito
Copy link

alcroito commented Jul 30, 2024

Hi,

Thanks for writing this tool, it greatly helps to quickly visualize an SBOMs document content.

I was wondering if it would be possible to add a feature to display one more table that lists the package's PURL and CPE values?

@anthonyharrison anthonyharrison added the enhancement New feature or request label Aug 12, 2024
@anthonyharrison
Copy link
Owner

@alcroito Thanks for the suggestion.

The PURL value is already used to show the package ecosystem and the data in the CPE is used for supplier information. Are you suggesting that the full PURL and CPE values are shown for each package?

@alcroito
Copy link
Author

Indeed. That it is my suggestion.

@alcroito
Copy link
Author

To clarify, for PURL, if the purl type is generic, showing just generic for the package ecosystem field doesn't provide much value without showing some extra metadata. Hence the desire to show the full purl value.

I'm not sure I follow your comment about CPE being used for supplier info. Searching for cpe in https://github.com/anthonyharrison/sbom2doc/blob/main/sbom2doc/generator.py shows no hits. And searching for supplier suggests the code only reads the supplier that was specified via the package explicitly.

But even if the supplier is derived from CPE via some other code path, i still think there's value in showing the full cpe if requested.

@alcroito
Copy link
Author

Thanks for implementing this!

I noticed that only one PURL and CPE is shown per package.

Sometimes a package might have more than one PURL or CPE.

For example an upstream vendor CPE, and a patched vendor-specific CPE.
Same with PURLs, one for the package upstream url, and one for a version specific to a project, which has patched sources.

Would you be open to a PR that shows all the CPE and PURL values of a package?

@alcroito
Copy link
Author

I pushed a PR in case that's something you are open to adding.

#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants