[TS] add missing channel constants #4579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. This fixes the problem. Note, there are still missing methods for lexer commends, like setChannel(). Some of the set/get methods, which are in Java, are inconsistent in TypeScirpt. For example, _type in TypeScript is a public field, whereas in Java there are get and set methods to hide direct access. But, I wonder about text in TypeScript vs _text in JavaScript, whereas in setText() in Java sets _text. There is no The fields in the lexer object are used when calling emit(). I can work around the lexer interface by directly manipulating the token itself by overriding emit(). |
|
@kaby76 can you file separate issues/PRs for these other missing items ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title says it all
Fixes #4572