Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address breaking adapter API changes in #4192 #8

Closed
Theo-Steiner opened this issue Mar 5, 2022 · 2 comments
Closed

Address breaking adapter API changes in #4192 #8

Theo-Steiner opened this issue Mar 5, 2022 · 2 comments

Comments

@Theo-Steiner
Copy link
Contributor

Up until a few days ago @FireMakeThunder's fix for the previous breaking adapter changes worked great, but in rapidly changing svelte-kit land nothing stays the same and there again have been breaking changes to the adapter API, that will need to be addressed for this adapter to work properly.
sveltejs/kit#4192 moved the prerendering from the adapt to the build step and introduced a config option for adapter-static like behaviour at config.kit.prerender.default.

Until a PR for addressing this breaking change is merged, you can still use this adapter by simply installing npm install -D Theo-Steiner/sveltekit-adapter-browser-extension and modify your config to look like this:

import adapterBrowserExtension from 'sveltekit-adapter-browser-extension';

/** @type {import('@sveltejs/kit').Config} */
const config = {
	kit: {
		prerender: {
			default: true
		},
		adapter: adapterBrowserExtension(),
		appDir: 'ext'
	}
};

export default config;
@Theo-Steiner
Copy link
Contributor Author

this also addresses #6

@antony
Copy link
Owner

antony commented Mar 8, 2022

Thank you!

@antony antony closed this as completed Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants