Update Rancher test script to skip sig-network test #6377

jainpulkit22 · 2024-05-28T10:15:32Z

Update Rancher test script to skip sig-network test while running conformance and network-policy tests on a rancher cluster.
Fixes #6426.

jainpulkit22 · 2024-05-28T10:15:59Z

/test-rancher-e2e

jainpulkit22 · 2024-05-28T10:49:33Z

/test-rancher-e2e

jainpulkit22 · 2024-05-28T13:02:28Z

/test-rancher-e2e

jainpulkit22 · 2024-05-29T06:40:09Z

/test-rancher-e2e

jainpulkit22 · 2024-05-29T09:10:57Z

/test-rancher-e2e

jainpulkit22 · 2024-05-29T12:14:12Z

/test-rancher-conformance

jainpulkit22 · 2024-05-29T12:14:21Z

/test-rancher-networkpolicy

rajnkamr · 2024-05-30T04:43:43Z

/test-rancher-conformance

rajnkamr · 2024-05-30T05:18:23Z

/test-rancher-networkpolicy

jainpulkit22 · 2024-05-30T08:32:58Z

/test-rancher-conformance

jainpulkit22 · 2024-05-30T10:30:28Z

/test-rancher-conformance

jainpulkit22 · 2024-05-30T11:01:51Z

/test-rancher-networkpolicy

jainpulkit22 · 2024-05-31T10:32:11Z

/test-rancher-conformance

rajnkamr · 2024-06-03T04:33:07Z

/test-rancher-networkpolicy

jainpulkit22 · 2024-06-03T06:56:03Z

/test-rancher-conformance

luolanzone · 2024-06-04T09:34:11Z

build/charts/antrea/README.md

@@ -12,7 +12,7 @@ Kubernetes networking based on Open vSwitch

 ## Requirements

-Kubernetes: `>= 1.16.0-0`
+Kubernetes: `>= 1.19.0-0`


Hi @jainpulkit22 can you submit a seperate PR for this version update? we need to backport both here #6396

sure I can, I added it here because verify docs check were failing

@luolanzone done PR: #6397

@jainpulkit22 , the changes are still visible in this PR as in #6397

XinShuYang · 2024-06-04T09:46:46Z

ci/run-k8s-e2e-tests.sh

@@ -138,6 +140,11 @@ case $key in
    SYSTEMD_LOGS_IMAGE="$2"
    shift 2
    ;;
+    --rancher-testbed)
+    RANCHER=true
+    DEFAULT_E2E_CONFORMANCE_SKIP="${DEFAULT_E2E_CONFORMANCE_SKIP}|\[sig-network\]"


May I know the background info of this PR? Why we skip sig-network in rancher test?

sig-network test is not supported in the current testing version of rancher

Could you be more specific about "not supported"? Which tests fail? Due to test itself, rancher, or antrea issue? There should an issue with details first to justify the PR and to follow up.

Sure, i will create an issue for the same.

@jainpulkit22 I saw you mentioned [sig-network] Ingress API should support creating Ingress API operations [Conformance] was not supported for the Rancher cluster. If so, we can only skip this test case, not the entire sig-network test suite.

Skipping the entire test suite just because one case doesn't make sense.

There is no detail or reference why the test failed so it can't justify why it should be skipped.

Even if the test should be skipped, the current way complicates the script unnecessarily, it should just parameterize the skipped test when invoking the script, instead of customiing the script for rancher.

okay will update the code, and add more logs to the issue as well.

Using [sig-network] will cause all tests with this label to be skipped. You can refer to our configuration in the NETWORKPOLICY_SKIP to skip individual test case.

antrea/ci/jenkins/test.sh

Line 50 in 683a72f

NETWORKPOLICY_SKIP="NetworkPolicyLegacy|should allow egress access to server in CIDR block|should enforce except clause while egress access to server in CIDR block"

jainpulkit22 · 2024-06-07T11:59:22Z

/test-rancher-conformance

jainpulkit22 · 2024-06-07T13:31:30Z

/test-rancher-conformance

jainpulkit22 · 2024-06-10T05:43:20Z

/test-rancher-conformance

jainpulkit22 · 2024-06-11T05:58:24Z

/test-rancher-conformance

jainpulkit22 · 2024-06-11T07:16:13Z

/test-rancher-conformance

jainpulkit22 · 2024-06-18T09:08:03Z

/test-rancher-conformance

rajnkamr · 2024-06-24T04:33:06Z

ci/jenkins/test-rancher.sh

@@ -236,9 +238,9 @@ function run_conformance {

    set +e
    if [[ "$TESTCASE" =~ "conformance" ]]; then
-        ${WORKSPACE}/ci/run-k8s-e2e-tests.sh --e2e-conformance --log-mode $MODE --image-pull-policy ${IMAGE_PULL_POLICY} --kubernetes-version "auto" > ${WORKSPACE}/test-result.log
+        ${WORKSPACE}/ci/run-k8s-e2e-tests.sh --e2e-conformance --log-mode $MODE --image-pull-policy ${IMAGE_PULL_POLICY} --kubernetes-version "auto" --rancher-testbed > ${WORKSPACE}/test-result.log


Do we have a log rotation policy for this testbed ?, log rotation policy is a good practice to manage the growth of log files and to ensure that you have a consistent and manageable logging strategy for test-result.log. Log rotation typically involves periodically archiving old log files and deleting them after a certain period or when they reach a certain size, to prevent disk space from being exhausted.

jainpulkit22 · 2024-08-01T10:12:39Z

/test-rancher-conformance

Signed-off-by: Pulkit Jain <pulkit.jain@broadcom.com>

github-actions · 2024-11-07T00:04:44Z

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days. You can add a label "lifecycle/frozen" to skip stale checking.

jainpulkit22 force-pushed the rancher-script branch from c78261c to 85d1fc5 Compare May 28, 2024 10:49

jainpulkit22 force-pushed the rancher-script branch from 85d1fc5 to 04d9d13 Compare May 28, 2024 13:02

jainpulkit22 force-pushed the rancher-script branch from 04d9d13 to c9232cb Compare May 29, 2024 06:39

jainpulkit22 force-pushed the rancher-script branch from c9232cb to cd97439 Compare May 30, 2024 08:32

jainpulkit22 force-pushed the rancher-script branch from cd97439 to a8248fd Compare May 31, 2024 10:30

jainpulkit22 force-pushed the rancher-script branch from a8248fd to 48a01dc Compare June 3, 2024 06:45

jainpulkit22 marked this pull request as ready for review June 3, 2024 06:45

jainpulkit22 force-pushed the rancher-script branch from 48a01dc to 13418c3 Compare June 3, 2024 06:55

jainpulkit22 changed the title ~~[WIP]Update Rancher test script~~ Update Rancher test script to skip sig-network test Jun 3, 2024

jainpulkit22 requested review from rajnkamr and XinShuYang June 3, 2024 07:11

jainpulkit22 force-pushed the rancher-script branch 2 times, most recently from fc151cd to 4c54e7f Compare June 4, 2024 08:53

rajnkamr added area/test/jenkins Issue about jenkins setup code area/test/infra Issues or PRs related to test infrastructure (Jenkins configuration, Ansible playbook, Kind wrappers labels Jun 4, 2024

luolanzone reviewed Jun 4, 2024

View reviewed changes

XinShuYang reviewed Jun 4, 2024

View reviewed changes

jainpulkit22 requested a review from XinShuYang June 6, 2024 05:14

jainpulkit22 force-pushed the rancher-script branch from 4c54e7f to a54e210 Compare June 7, 2024 11:58

jainpulkit22 force-pushed the rancher-script branch from a54e210 to 9a0b722 Compare June 10, 2024 05:42

jainpulkit22 marked this pull request as draft June 10, 2024 06:31

jainpulkit22 force-pushed the rancher-script branch from 9a0b722 to 2e2371b Compare June 11, 2024 05:58

jainpulkit22 force-pushed the rancher-script branch from 2e2371b to 17ba3b5 Compare June 11, 2024 07:12

jainpulkit22 marked this pull request as ready for review June 11, 2024 07:16

jainpulkit22 force-pushed the rancher-script branch from 17ba3b5 to 7d0d723 Compare June 18, 2024 06:44

jainpulkit22 marked this pull request as draft June 18, 2024 06:44

jainpulkit22 force-pushed the rancher-script branch from 7d0d723 to 3cd4f99 Compare June 18, 2024 09:07

rajnkamr reviewed Jun 24, 2024

View reviewed changes

jainpulkit22 force-pushed the rancher-script branch from 3cd4f99 to fc4ea11 Compare August 1, 2024 10:11

Update Rancher test script to skip sig-network test

35f3fbb

Signed-off-by: Pulkit Jain <pulkit.jain@broadcom.com>

jainpulkit22 force-pushed the rancher-script branch from fc4ea11 to 35f3fbb Compare August 2, 2024 10:32

jainpulkit22 marked this pull request as ready for review August 8, 2024 06:40

jainpulkit22 marked this pull request as draft August 8, 2024 06:40

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 7, 2024

rajnkamr removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 7, 2024

Update Rancher test script to skip sig-network test #6377

Are you sure you want to change the base?

Update Rancher test script to skip sig-network test #6377

Conversation

jainpulkit22 commented May 28, 2024 • edited Loading

jainpulkit22 commented May 28, 2024

jainpulkit22 commented May 28, 2024

jainpulkit22 commented May 28, 2024

jainpulkit22 commented May 29, 2024

jainpulkit22 commented May 29, 2024

jainpulkit22 commented May 29, 2024

jainpulkit22 commented May 29, 2024

rajnkamr commented May 30, 2024

rajnkamr commented May 30, 2024

jainpulkit22 commented May 30, 2024

jainpulkit22 commented May 30, 2024

jainpulkit22 commented May 30, 2024

jainpulkit22 commented May 31, 2024

rajnkamr commented Jun 3, 2024

jainpulkit22 commented Jun 3, 2024

luolanzone Jun 4, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jainpulkit22 commented Jun 7, 2024

jainpulkit22 commented Jun 7, 2024

jainpulkit22 commented Jun 10, 2024

jainpulkit22 commented Jun 11, 2024

jainpulkit22 commented Jun 11, 2024

jainpulkit22 commented Jun 18, 2024

Choose a reason for hiding this comment

jainpulkit22 commented Aug 1, 2024

github-actions bot commented Nov 7, 2024

jainpulkit22 commented May 28, 2024 •

edited

Loading

luolanzone Jun 4, 2024 •

edited

Loading