Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate image registry to registry.k8s.io #183

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

ArkaSaha30
Copy link
Contributor

This PR will migrate image registry from k8s.gcr.io to registry.k8s.io.
Fixes: kubernetes/k8s.io#4780

Signed-off-by: ArkaSaha30 arkasaha30@gmail.com

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #183 (7cffd89) into main (6d42898) will increase coverage by 12.34%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #183       +/-   ##
===========================================
+ Coverage   47.07%   59.41%   +12.34%     
===========================================
  Files          67       32       -35     
  Lines        6834     3440     -3394     
  Branches       41        0       -41     
===========================================
- Hits         3217     2044     -1173     
+ Misses       3363     1170     -2193     
+ Partials      254      226       -28     
Flag Coverage Δ
unit-tests 59.41% <ø> (+15.71%) ⬆️

see 36 files with indirect coverage changes

@elton-furtado elton-furtado requested a review from yanjunz97 March 22, 2023 02:40
@yanjunz97
Copy link
Contributor

/theia-test-e2e

@yanjunz97
Copy link
Contributor

Thanks @ArkaSaha30 for your contribution! Maybe you also want to change the occurrence here?

DOCKER_IMAGES=("k8s.gcr.io/e2e-test-images/agnhost:2.29" \

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
@yanjunz97
Copy link
Contributor

/theia-test-e2e

Copy link
Contributor

@yanjunz97 yanjunz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanjunz97 yanjunz97 merged commit 2c053cd into antrea-io:main Mar 24, 2023
Dhruv-J pushed a commit to Dhruv-J/theia that referenced this pull request Mar 29, 2023
Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Umbrella Issue] Migrate CNCF Ecosystem projects from k8s.gcr.io to registry.k8s.io
2 participants