New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chart): chart.options should remove node #5103

Merged

hustcc merged 1 commit into v5 from fix/chart-options-remove-node

May 26, 2023

Member

pearmini commented May 26, 2023

修复 chart.options 不能删除节点的问题：

const chart = new Chart({});

chart.options({
  type: 'view',
  children: [{ type: 'line' }, { type: 'point' }],
});

chart.options({
  type: 'view',
  children: [{ type: 'line' }],
});

expect(chart.options()).toEqual({
  type: 'view',
  children: [{ type: 'line' }],
});


          fix(chart): chart.options should remove node

e0e1fc4

pearmini requested a review from hustcc

May 26, 2023 08:02

hustcc approved these changes

View reviewed changes

hustcc merged commit 6949459 into v5

hustcc deleted the fix/chart-options-remove-node branch

May 26, 2023 10:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet