Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(brush): emit brush remove #5170

Merged
merged 1 commit into from
Jun 8, 2023
Merged

fix(brush): emit brush remove #5170

merged 1 commit into from
Jun 8, 2023

Conversation

pearmini
Copy link
Member

@pearmini pearmini commented Jun 8, 2023

  • 存在问题：之前 chart.emit('brush:remove') 会出现递归调用的情况。
  • 解决办法：通过 nativeEvent 判断一下。

@pearmini pearmini requested a review from hustcc June 8, 2023 06:02
@pearmini pearmini merged commit 1a554e5 into v5 Jun 8, 2023
@pearmini pearmini deleted the fix/emit-brush-remove branch June 8, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pearmini @hustcc